Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated functions #4185

Merged
merged 2 commits into from
Aug 9, 2016
Merged

remove deprecated functions #4185

merged 2 commits into from
Aug 9, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jul 30, 2016

When merged this pull request will:

  • title

@commy2 commy2 added the kind/cleanup Release Notes: **CHANGED:** label Jul 30, 2016
@commy2 commy2 added this to the 3.7.0 milestone Jul 30, 2016
@commy2 commy2 self-assigned this Jul 30, 2016
@commy2 commy2 force-pushed the cleanup-deprecated branch from 05206f4 to 1ffe313 Compare July 30, 2016 09:16
@commy2 commy2 removed the status/WIP label Jul 30, 2016
@commy2
Copy link
Contributor Author

commy2 commented Jul 30, 2016

Bye bye filter, map and execRemoteFnc.

2014-2016
KoffeinFlummi/AGM@bcc79f0
KoffeinFlummi/AGM@3a36ca4

@commy2 commy2 merged commit 5e40c24 into master Aug 9, 2016
@commy2 commy2 deleted the cleanup-deprecated branch August 9, 2016 16:34
kymckay
kymckay reviewed Aug 9, 2016
View reviewed changes
addons/common/XEH_postInit.sqf
]
};

["ace_playerInventoryChanged", [ACE_player, ACE_player call _fnc_getAllGear]] call CBA_fnc_localEvent;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing {} ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aye

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CBA_fnc_localEvent != CBA_fnc_addEventHandler

I want to pass the return value of _fnc_getAllGear and not some

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aye, right

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 Ah yep, totally overlooked that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@commy2 commy2

Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@commy2 @kymckay @nicolasbadano