-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert log macros to cba versions #4282
Conversation
We want to replace ACEX headless/viewrestriction is using some of ace's log macros Do we really want end users seeing the big UI warning on screen? I think we should really think about when to use the ERROR macro and make sure it won't show up for trivial errors. |
We should update ACEX soon anyways, 2 feature-breaking bugs in current release of it. |
I think so, but it's true that we shouldn't use that for trivial things. There always is the warning macro for those. |
When merged this pull request will:
This also has the benefit of it using this new cool error pop up:
ACE_ERRORFORMAT
). I have no idea what their purpose would be. They are used nowhere.I also used noticed that we already use the CBA macros in some places. This would make it overall more consistent.