Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert log macros to cba versions #4282

Merged
merged 6 commits into from
Oct 2, 2016
Merged

convert log macros to cba versions #4282

merged 6 commits into from
Oct 2, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Aug 22, 2016

When merged this pull request will:

  • converts the ACE logging macros to the CBA ones.
  • CBA ones will receive our cool formatting after the next cba update

This also has the benefit of it using this new cool error pop up:
https://camo.githubusercontent.com/69f9767d74e54dbf005d5f31f1305b1a2a33e35f/687474703a2f2f692e696d6775722e636f6d2f304b66303838412e706e67

  • it also deletes the format-version (e.g. ACE_ERRORFORMAT). I have no idea what their purpose would be. They are used nowhere.

I also used noticed that we already use the CBA macros in some places. This would make it overall more consistent.

@commy2 commy2 added kind/cleanup Release Notes: **CHANGED:** target/next-cba labels Aug 22, 2016
@commy2 commy2 added this to the 3.7.0 milestone Aug 22, 2016
@commy2 commy2 self-assigned this Aug 22, 2016
@PabstMirror
Copy link
Contributor

PabstMirror commented Aug 22, 2016

We want to replace // #define CBA_DEBUG_SYNCHRONOUS with // #define DEBUG_SYNCHRONOUS

ACEX headless/viewrestriction is using some of ace's log macros

Do we really want end users seeing the big UI warning on screen? I think we should really think about when to use the ERROR macro and make sure it won't show up for trivial errors.

@jonpas
Copy link
Member

jonpas commented Aug 22, 2016

ACEX headless/viewrestriction is using some of ace's log macros

We should update ACEX soon anyways, 2 feature-breaking bugs in current release of it.

@commy2
Copy link
Contributor Author

commy2 commented Aug 22, 2016

Do we really want end users seeing the big UI warning on screen? I think we should really think about when to use the ERROR macro and make sure it won't show up for trivial errors.

I think so, but it's true that we shouldn't use that for trivial things. There always is the warning macro for those.

@thojkooi thojkooi modified the milestones: 3.7.0, 3.8.0 Sep 4, 2016
@thojkooi thojkooi merged commit 05d30c5 into master Oct 2, 2016
@thojkooi thojkooi deleted the cba-log-macros branch October 2, 2016 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants