Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase blood bag flow rate for basic medical #4306

Merged
merged 2 commits into from
Sep 1, 2016

Conversation

PabstMirror
Copy link
Contributor

  • Increase flow rate for basic medical (41ml/sec in an arm vein probably doesn't feel great 😄 )
  • Don't queue bags - (2 bags flow twice as fast, instead of just doubling the total to add)

Uses a single unit variable QGVAR(ivBags) to hold all bag info.
We can skip calculations and syncing if the value is nil (no bags) which should be the common case.

- Increase flow rate for basic medical
- Don't queue bags
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Aug 27, 2016
@PabstMirror PabstMirror added this to the 3.7.0 milestone Aug 27, 2016
@thojkooi
Copy link
Contributor

This PR removes the seperate lists for blood, plasma and saline. I think we still want to keep track of the types of IV that are providing the regen. It does not matter for basic, but could matter a lot for advanced medical in the near future.

@PabstMirror
Copy link
Contributor Author

In fnc_treatmentIVLocal:

_bloodBags pushBack [_volumeAdded]; // Future BagType: [_volumeAdded, _typeOf]

I was thinking in the future the ivBags array would hold arrays with the volume and type when we had a use for it. This lets us just check a single variable for speed, but we can still have all the info if we need it.

@thojkooi thojkooi merged commit c4d2383 into master Sep 1, 2016
@thojkooi thojkooi deleted the increaseBloodBagForBasic branch September 1, 2016 10:46
thojkooi pushed a commit that referenced this pull request Sep 6, 2016
PabstMirror added a commit that referenced this pull request Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants