Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End path drawing when passing through Geom/Fire #4385

Merged
merged 2 commits into from
Sep 23, 2016
Merged

Conversation

PabstMirror
Copy link
Contributor

Ends grenade arc drawing when throw will collide with the GEOM or FIRE LOD.

Unfortunately many CUP buildings have bulletproof windows that do not pass grenades.
There are also other cases where we could show a throw as being safe when it will be blocked such as A3 Gratings.
However this also could introduce warnings when the shot will be fine.

But I believe the worst thing we can do is to tell the user that a shot will be safe when it could fail and kill their team. Warning about a "false negative" is far less critical.

  • Neither of these shots are possible, but would have been shown as safe:
    20160912203918_1
  • This shot is actually fine, but we still show a warning:
    20160912205522_1

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Sep 13, 2016
@PabstMirror PabstMirror added this to the 3.7.1 milestone Sep 13, 2016
@PabstMirror
Copy link
Contributor Author

Also, we can get info on the actual hitpoint with

private _hitpoint = [cursorObject, "FIRE"] intersect [ASLtoAGL _prevTrajASL, ASLToAGL _newTrajASL];

Which should give "Glass_2_hide" which would match:

class Glass_2_hitpoint {
    armor = 0.001;
    material = -1;
    name = "Glass_2";
    visual = "Glass_2_hide";
    passThrough = 0;
    radius = 0.4;
    convexComponent = "Glass_2_hide";

But I see no difference between A2 and A3 building configs. I believe the problem is with the model material, but I am not sure.

@jonpas
Copy link
Member

jonpas commented Sep 13, 2016

This looks good to me, overall I'd say it's an improvement, "false negative" is indeed better. I will add documentation for that in this PR as I think documenting that will be useful, so marking with WIP.

@jonpas jonpas modified the milestones: 3.7.1, 3.8.0 Sep 18, 2016
@PabstMirror PabstMirror merged commit b7dfdc6 into master Sep 23, 2016
@PabstMirror PabstMirror deleted the throwingWarnGeom branch September 23, 2016 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants