Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more immersive dogtag interaction #4446

Merged
merged 3 commits into from
Sep 21, 2016
Merged

more immersive dogtag interaction #4446

merged 3 commits into from
Sep 21, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Sep 20, 2016 •
edited
Loading

When merged this pull request will:

  • plays animation, rustling sounds and delays the showing of the dogtag when applicable
  • switches displayText (hintSilent) to better looking displayTextStructured
  • puts dogtag interaction position on neck instead of main interaction point

@commy2 commy2 added kind/enhancement Release Notes: **IMPROVED:** status/WIP labels Sep 20, 2016
@commy2 commy2 added this to the 3.8.0 milestone Sep 20, 2016
@commy2 commy2 self-assigned this Sep 20, 2016
@commy2 commy2 removed the status/WIP label Sep 20, 2016
nicolasbadano
nicolasbadano approved these changes Sep 21, 2016
View reviewed changes
Copy link
Contributor

@nicolasbadano nicolasbadano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@commy2 commy2 merged commit 03d83b6 into master Sep 21, 2016
@commy2 commy2 deleted the tweak-dogtags branch September 21, 2016 07:07
@PabstMirror PabstMirror mentioned this pull request Sep 26, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasbadano nicolasbadano nicolasbadano approved these changes

Assignees

@commy2 commy2

Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@commy2 @nicolasbadano