Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ambient Sounds #4470

Merged
merged 1 commit into from
Oct 1, 2016
Merged

Fix Ambient Sounds #4470

merged 1 commit into from
Oct 1, 2016

Conversation

PabstMirror
Copy link
Contributor

Fix #4418

  • Remove leading \ for configfile sounds
  • Cleanup randomized location code

Config has leading slash, but playSound doesn't want it
playSound3d ["\a3\Ui_f\data\Sound\CfgNotifications\scoreRemoved.wss", player]; // throws rpt error
playSound3d ["a3\Ui_f\data\Sound\CfgNotifications\scoreRemoved.wss", player]; // works

Fix #4418
- Remove leading `\` for configfile sounds
- Cleanup randomized location code
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Sep 27, 2016
@PabstMirror PabstMirror added this to the 3.8.0 milestone Sep 27, 2016
@thojkooi thojkooi merged commit 95da004 into master Oct 1, 2016
@thojkooi thojkooi deleted the cleanupMissionSounds branch October 1, 2016 08:27
@commy2
Copy link
Contributor

commy2 commented Oct 1, 2016

missing private for _soundPath

@commy2
Copy link
Contributor

commy2 commented Oct 1, 2016

nvm. it's in the array at the top. not used to this anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants