Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix formating of CBA version check #4511

Merged
merged 1 commit into from
Oct 5, 2016
Merged

fix formating of CBA version check #4511

merged 1 commit into from
Oct 5, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Oct 5, 2016

When merged this pull request will:

  • changes:
[ACE] (common) INFO: ACE is version 3.7.0.6.
[ACE] (common) INFO: CBA is version [3,1,0,160928] [min required [3,1,0]]

to:

[ACE] (common) INFO: ACE is version 3.7.0.6.
[ACE] (common) INFO: CBA is version 3.1.0.160928 (min required 3.1.0)

OCD

@commy2 commy2 added the kind/enhancement Release Notes: **IMPROVED:** label Oct 5, 2016
@commy2 commy2 added this to the 3.8.0 milestone Oct 5, 2016
PabstMirror
PabstMirror approved these changes Oct 5, 2016
View reviewed changes
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For format, sometimes I will put variables inside blocks just to make it easier to tell if they are empty/nil. But this is fine.

@PabstMirror PabstMirror merged commit 2e147b3 into master Oct 5, 2016
@PabstMirror PabstMirror deleted the format-cba-version-log branch October 5, 2016 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@commy2 @jonpas @PabstMirror