Add Zeus Module for FRIES #4597
Conversation
| @@ -14,3 +14,4 @@ QGVAR(GlobalSkillAI) addPublicVariableEventHandler FUNC(moduleGlobalSetSkill); | |||
| [QGVAR(modulePatrolArea), CBA_fnc_taskPatrol] call CBA_fnc_addEventHandler; | |||
| [QGVAR(moduleSearchNearby), CBA_fnc_searchNearby] call CBA_fnc_addEventHandler; | |||
| [QGVAR(moduleSearchArea), CBA_fnc_taskSearchArea] call CBA_fnc_addEventHandler; | |||
| [QGVAR(equipFries), EFUNC(fastroping,equipFRIES)] call CBA_fnc_addEventHandler; | |||
There was a problem hiding this comment.
Can just be added on server I guess since it won't be called outside of server.
| <English>%1 is not fastrope compatible.</English> | ||
| </Key> | ||
| <Key ID="STR_ACE_Zeus_CantRemoveFRIES"> | ||
| <English>Can't remove FRIES, ropes are deployed.</English> |
There was a problem hiding this comment.
"Unable to remove..." would be better.
| }; | ||
|
|
||
| class ACE_Curator { | ||
| GVAR(captives) = "ace_captives"; | ||
| GVAR(medical) = "ace_medical"; | ||
| GVAR(cargoAndRepair)[] = {"ace_cargo", "ace_repair"}; | ||
| GVAR(fastRoping) = "ace_fastroping"; |
There was a problem hiding this comment.
I still think this should be GVAR(fastroping) like the module, everywhere else as well, fastRoping capitalization looks weird IMO. GVAR(cargoAndRepair) is exception because it's for 2 components.
|
Also, don't worry about translations, those come later by translators. ;) |
|
Figured so, just thought I'd point it out. |
| if !(alive _mouseOverUnit) then { | ||
| [LSTRING(OnlyAlive)] call EFUNC(common,displayTextStructured); | ||
| } else { | ||
| _config = configFile >> "CfgVehicles" >> typeOf _mouseOverUnit; |
| [LSTRING(OnlyAlive)] call EFUNC(common,displayTextStructured); | ||
| } else { | ||
| _config = configFile >> "CfgVehicles" >> typeOf _mouseOverUnit; | ||
| _displayName = getText (_config >> "displayName"); |
| if !(isNumber (_config >> QEGVAR(fastroping,enabled))) then { | ||
| [format [localize LSTRING(NotFastRopeCompatible), _displayName]] call EFUNC(common,displayTextStructured); | ||
| } else { | ||
| _fries = GETVAR(_mouseOverUnit,EGVAR(fastroping,FRIES),objNull); |
|
Will this allow FRIES to be equipped on helicopters which are not configured for it? |
|
No. That's simply not possible because fastroping has no idea where to attach it to. |
|
There's no way to assign default positions for helicopters without support? The ropes would be hanging from the hull, but at least FRIES would be usable on more than 2 helicopters. 😃 |
|
There is no way to automatically detect a good position for the ropes, ensuring that they dont clip into the helo, are near doors etc. Every vanilla helicopter except the Little Bird supports fastroping, CUP has their helicopter properly configured and we provide a compat for RHS which adds it to their helicopters as well. I have no idea where you got your "only 2 helicopters" from. |
|
Gotcha. There's only a couple of them who has the FRIES checkbox in 3den, so I missed a dozen. 😆 |
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ["ace_settingsInitialized",{ | |||
| // Only add an InitPost EH if setting is enabled (and apply retroactively) | |||
| if (isServer && GVAR(autoAddObjects)) then { | |||
| if (isServer && {GVAR(autoAddObjects)}) then { | |||
There was a problem hiding this comment.
It doesn't really matter, but would this not be slower in this case?
There was a problem hiding this comment.
It's always slower on the server, but faster on the clients. Since there are more clients than servers usually, this is overall faster.
Not that it matters.
|
👍 Forgot I meant to merge this one on monday |
When merged this pull request will: