Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACE_Chemlight_Shield not public #4612

Merged
merged 1 commit into from
Nov 12, 2016
Merged

ACE_Chemlight_Shield not public #4612

merged 1 commit into from
Nov 12, 2016

Conversation

AndreasBrostrom
Copy link
Contributor

When merged this pull request will:
Changed ACE_Chemlight_Shield to public from protected

@AndreasBrostrom
ACE_Chemlight_Shield not public
f28db10 
Changed `ACE_Chemlight_Shield` to `public` from `protected`
@jonpas jonpas added the kind/bug-fix Release Notes: **FIXED:** label Oct 29, 2016
@jonpas jonpas added this to the 3.8.2 milestone Oct 29, 2016
@jonpas
Copy link
Member

jonpas commented Oct 29, 2016

Tagging @voiperr

@commy2
Copy link
Contributor

commy2 commented Oct 30, 2016

Same for ACE_Chemlight_Shield_Green which all the colored ones inherit from.

@AndreasBrostrom
Copy link
Contributor Author

That I thought was intentional.

@commy2
Copy link
Contributor

commy2 commented Oct 30, 2016

Why though?

@AndreasBrostrom
Copy link
Contributor Author

Cause I thought the in use one was supposed to be protected while the in used one was not to be protected. To avoid people grabbing a ready one from the arsenal (or similar systems).

@commy2
Copy link
Contributor

commy2 commented Oct 31, 2016

So ACE_Chemlight_Shield is basically the empty one? I had to google what a chemlight shield is.

@AndreasBrostrom
Copy link
Contributor Author

Hehe, yes the ACE_Chemlight_Shield is the empty one.

commy2
commy2 approved these changes Oct 31, 2016
View reviewed changes
Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not @voiperr but lgtm

@PabstMirror PabstMirror merged commit c4c9869 into acemod:master Nov 12, 2016
@thojkooi
Copy link
Contributor

Added to 3.8.2 branch

thojkooi pushed a commit that referenced this pull request Nov 17, 2016
@AndreasBrostrom @thojkooi
ACE_Chemlight_Shield not public (#4612)
e73d20f 
Changed `ACE_Chemlight_Shield` to `public` from `protected`
@AndreasBrostrom AndreasBrostrom deleted the patch-2 branch May 31, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commy2 commy2 commy2 approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.8.2
Development

Successfully merging this pull request may close these issues.
5 participants
@AndreasBrostrom @jonpas @commy2 @thojkooi @PabstMirror