Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Full Repair menu not shown when damage returns 0 #4621

Merged
merged 1 commit into from
Nov 9, 2016

Conversation

Dystopian
Copy link
Contributor

Sometimes damage command returns 0 even if vehicle is almost fully destroyed. It's mentioned in Notes section on that wiki page. I found it can easily reproduced with HMG fire at Hunter.
damage can be replaced with getAllHitPointsDamage.

damage is also used for vehicles in fnc_normalizeHitPoints.sqf and fnc_setHitPointDamage.sqf, but I didn't managed to understand the sense.

@PabstMirror PabstMirror added this to the 3.8.2 milestone Nov 4, 2016
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Nov 4, 2016
@PabstMirror PabstMirror merged commit ff961a5 into acemod:master Nov 9, 2016
@Dystopian Dystopian deleted the fix_fullrepair branch November 26, 2016 16:02
@Dystopian
Copy link
Contributor Author

Could anyone say what I should do with my local branch fix_fullrepair please? I've already deleted branch Dystopian:fix_fullrepair from GitHub PR web interface, but my local branch is still in "git branch" list.
git branch -d fix_fullrepair says:

error: The branch 'fix_fullrepair' is not fully merged.
If you are sure you want to delete it, run 'git branch -D fix_fullrepair'.

git remote prune origin:

Pruning origin
URL: git@github.com:Dystopian/ACE3.git
* [pruned] origin/fix_fullrepair

but git branch still says:

fix_fuel_station
fix_fullrepair
* master

Is 'git branch -D fix_fullrepair' a good choice now?

@bux
Copy link
Member

bux commented Nov 27, 2016

@Dystopian I'd suggest you join our public chat (http://slackin.ace3mod.com/). There's a channel #git dedicated to git usage/problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants