Prevent switching to weapon while carrying fuel nozzle #4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, but why is |
|
I don't know, it's used like that in other refuel places. |
PabstMirror
approved these changes
Nov 12, 2016
|
@jonpas - I just flipped the PFEH exitWith condition if you want to double check, otherwise looks good to go. |
|
Nice catch @PabstMirror ! |
|
Added to 3.8.2 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Refuel should use a
canInteractWith(like carrying does), but that will need a bigger rework. Because of it not usingcanInteractWithAdvanced Throwing is possible while carrying a fuel nozzle or jerry can.Aditionally vanilla throwing is possible both with refuel and carrying, a
setAmmoframework for that would be nice, but have no time to work on it at the moment.