Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ballistics - Fixed 6.5mm magazine config #4641

Merged
merged 2 commits into from
Nov 8, 2016

Conversation

ulteq
Copy link
Contributor

@ulteq ulteq commented Nov 6, 2016

When merged this pull request will:

  • Add new 20rnd 6.5mm Creedmor and 6.5mm Lapua Scenar magazines
  • Fix incorrect QBU-88 (DMR_07_base_F) initSpeed
  • Fix 30rnd 6.5mm Creedmor and 30rnd 6.5mm Lapua Scenar magazine initSpeeds

Closes: #4636

@ulteq ulteq added config kind/bug-fix Release Notes: **FIXED:** status/cherrypick labels Nov 6, 2016
@ulteq ulteq added this to the 3.8.2 milestone Nov 6, 2016
@ulteq ulteq force-pushed the ballistics-new-20-round-apex-mags branch from 756bca7 to 5962a1d Compare November 6, 2016 19:29
@ulteq ulteq changed the title Ballistics - New 20 round apex mags Ballistics - Overworked 6.5mm magazine config Nov 6, 2016
@ulteq ulteq changed the title Ballistics - Overworked 6.5mm magazine config Ballistics - Fixed 6.5mm magazine config Nov 6, 2016
@KaiSforza
Copy link
Contributor

I just have to wonder why the caseless ammo is a higher velocity than the cased ammo. Shouldn't it be the opposite?

class ACE_20Rnd_65_Creedmor_mag: 20Rnd_650x39_Cased_Mag_F {
author = ECSTRING(common,ACETeam);
ammo = "ACE_65_Creedmor_Ball";
initSpeed = 808;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean for this to be 815, and the caseless to be 808, as you did for the Scenar?

Copy link
Contributor

@KaiSforza KaiSforza Nov 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, just looking at the data from that test I linked in my previous PR and from other places, it seems like the base speed (if we're considering a 16" barrel the base speed for the 6.5mm cartriges) should be around 760 for the creedmoor and lapua ammo.

@ulteq
Copy link
Contributor Author

ulteq commented Nov 7, 2016

I just have to wonder why the caseless ammo is a higher velocity than the cased ammo.

We currently do not simulate caseless ammo. We assume that all vanilla 6.5mm rounds are cased.

The muzzle velocity vs. barrel length mapping happens here:
https://github.com/KaiSforza/ACE3/blob/6fddb787e3d05610f206e0c19c7330f3f866e521/addons/ballistics/CfgAmmo.hpp#L188-L189

This is our current config for 6.5 mm Creedmor:

        ACE_muzzleVelocities[]={750, 820, 840, 852, 860};
        ACE_barrelLengths[]={254.0, 406.4, 508.0, 609.6, 660.4};

I just have to wonder why the caseless ammo is a higher velocity than the cased ammo.
The magazine initSpeed is multiplied by the weapon initSpeed.

MXM: initSpeed: 1.01842 30Rnd_65_Creedmor: initSpeed: 815 -> Muzzle velocity: 830
DMR_07: initSpeed: 1.06946 **20Rnd_65_Creedmor:** initSpeed: 808` -> Muzzle velocity: 864

The net muzzle velocity is higher even though the magazine initSpeed is lower.

Also, just looking at the data from that test that was done it seems like the base speed (if we're considering a 16" barrel the base speed for the 6.5mm cartriges) should be around 760 for the creedmoor and lapua ammo.

I'm more than willing to change the muzzle velocity vs. barrel length mappings when you can provide us plausible data for any ammo type in question.

Just curious, where did the 1.06051 come from?

I calculated it off the desired magazine initSpeed and the muzzle velocity vs. barrel length data.

It needs to fit into the following equation for as many magazines as possible:
weapon initSpeed = correct muzzle velocity / magazine initSpeed

Copy link
Contributor

@KaiSforza KaiSforza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the comment that was just posted, I approve of all the changes.

Copy link
Member

@bux bux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can't say anything about the values, but the config seems to look fine.

@ulteq ulteq merged commit 0580bdc into master Nov 8, 2016
@ulteq ulteq deleted the ballistics-new-20-round-apex-mags branch November 8, 2016 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants