Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FCS with no compat pbo required #4653

Merged
merged 3 commits into from
Nov 15, 2016
Merged

FCS with no compat pbo required #4653

merged 3 commits into from
Nov 15, 2016

Conversation

ulteq
Copy link
Contributor

@ulteq ulteq commented Nov 10, 2016 •
edited
Loading

Reincarnation of #3561

When merged this pull request will:

  • Add a correction to ACE_FCS to account for vanilla zeroing
  • Allow ACE_FCS to work without requiring a compatibility PBO

TODO
Think about hiding the vanilla zeroing control if necessary (Edit: I don't think that we should hide it)

Closes: #3561

@ulteq ulteq added the kind/enhancement Release Notes: **IMPROVED:** label Nov 10, 2016
@ulteq ulteq added this to the 3.9.0 milestone Nov 10, 2016
nicolasbadano
nicolasbadano approved these changes Nov 15, 2016
View reviewed changes
Copy link
Contributor

@nicolasbadano nicolasbadano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thanks @ulteq

@nicolasbadano nicolasbadano mentioned this pull request Nov 15, 2016
Closed
3 tasks
@ulteq ulteq merged commit 4df561e into master Nov 15, 2016
@ulteq ulteq deleted the fcs-no-compat-pbo branch November 15, 2016 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasbadano nicolasbadano nicolasbadano approved these changes

Assignees

@commy2 commy2

Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ulteq @nicolasbadano @commy2