Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules Cleanup #4813

Merged
merged 2 commits into from
Jan 14, 2017
Merged

Modules Cleanup #4813

merged 2 commits into from
Jan 14, 2017

Conversation

Neviothr
Copy link
Contributor

When merged this pull request will:

  • Do some minor cleanup in modules

Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newlines are required

class Extended_PostInit_EventHandlers {
class _ACE_modules { // using a _ so it is the first postInit to be executed
init = QUOTE(call COMPILE_FILE(XEH_postInit));
};
};
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our standards require newline at the end of file.

@jonpas jonpas added the kind/cleanup Release Notes: **CHANGED:** label Jan 11, 2017
@jonpas jonpas added this to the 3.9.0 milestone Jan 11, 2017
@PabstMirror PabstMirror merged commit ade87ad into acemod:master Jan 14, 2017
@bux
Copy link
Member

bux commented Jan 15, 2017

Thanks.

@Neviothr Neviothr deleted the modules-cleanup branch January 15, 2017 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants