Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CBA Accessory Functions for Laser mode switching #4855

Merged
merged 4 commits into from
Feb 25, 2017
Merged

Use CBA Accessory Functions for Laser mode switching #4855

merged 4 commits into from
Feb 25, 2017

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented Jan 24, 2017

When merged this pull request will:

  • Replaces ACE's laserpointer switching with CBA's accessory functions

@jonpas jonpas added kind/enhancement Release Notes: **IMPROVED:** target/next-cba labels Jan 24, 2017
@jonpas jonpas added this to the 3.9.0 milestone Jan 24, 2017
PabstMirror
PabstMirror approved these changes Jan 28, 2017
View reviewed changes
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do lose the setting check that prevented switching to a mode that wouldn't work.
But I think the benefits of moving to a common CBA keybind is worth it.

@jonpas
Copy link
Member Author

jonpas commented Jan 28, 2017

We do lose the setting check that prevented switching to a mode that wouldn't work.

You are right, this basically allows you to switch but it will just switch to a mode that won't do anything. Not sure what the best thing to do is to make it transparent to the user.

@PabstMirror
Copy link
Contributor

PabstMirror commented Jan 28, 2017 •
edited
Loading

What about adding an event in the CBA attachment handler?
We could listen for the event and handle it there

edit, in any case, it's not a default option, so shouldn't be a problem

@jonpas
Copy link
Member Author

jonpas commented Jan 28, 2017

An event sounds good.

@PabstMirror
Use CBA ACC EH to prevent switching to unusable lzr (#4860)
0e8df74 
* Use CBA ACC EH to prevent switching to unusable lzr

* Re-call CBA_accessory_fnc_switchAttachment
@PabstMirror PabstMirror modified the milestones: Ongoing, 3.9.0 Feb 2, 2017
@jonpas jonpas merged commit bc70571 into master Feb 25, 2017
@jonpas jonpas deleted the laserpointerCBAaccs branch February 25, 2017 16:16
@PabstMirror PabstMirror modified the milestones: 3.10.0, Ongoing Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jonpas @PabstMirror