Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify params in atragmx profile gunlist #4917

Merged
merged 1 commit into from
Feb 25, 2017
Merged

Verify params in atragmx profile gunlist #4917

merged 1 commit into from
Feb 25, 2017

Conversation

PabstMirror
Copy link
Contributor

  • Delay all init until first use
  • Verify each gun in profile list with isEqualTypeArray

Should fix #4910

@bux, if you can still reproduce the error, it would be great if you could try testing this branch.

@PabstMirror PabstMirror added kind/bug-fix Release Notes: **FIXED:** status/needs-testing labels Feb 18, 2017
@PabstMirror PabstMirror added this to the 3.9.1 milestone Feb 18, 2017
@bux
Copy link
Member

bux commented Feb 19, 2017

@PabstMirror No script error when opening the ATragMx anymore.
Seems to have fixed it. 👍

@PabstMirror PabstMirror merged commit 0bc1e12 into master Feb 25, 2017
@PabstMirror PabstMirror deleted the verifyGunList branch February 25, 2017 01:20
thojkooi pushed a commit that referenced this pull request Mar 13, 2017
@PabstMirror @thojkooi
Verify params in atragmx profile gunlist (#4917)
863d549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bux bux bux approved these changes

Assignees

@ulteq ulteq

Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.9.1
Development

Successfully merging this pull request may close these issues.

Script error when opening ATragMx
5 participants
@PabstMirror @bux @thojkooi @jonpas @ulteq