Fix AB water vapor pressure calc #4956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good find. |
TheMagnetar
reviewed
Mar 1, 2017
| @@ -94,7 +94,7 @@ double calculateAirDensity(double temperature, double pressure, double relativeH | |||
|
|
|||
| if (relativeHumidity > 0) { | |||
| double _pSat = 6.1078 * pow(10, ((7.5 * temperature) / (temperature + 237.3))); | |||
There was a problem hiding this comment.
Shouldn't 6.1078 (hPa) be converted to Pa directly here instead of converting it in vaporPressure? I find it more clear than later multiplying by 100.0 and having _pSat in hPa while vaporPressure in Pa
There was a problem hiding this comment.
Going to use 610.78 and added note
bux
approved these changes
Apr 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4951
This will effect both AtragMX and AB.
_pSatwas in hPa, needs to be converted to PaThis will require dll rebuild, so I'm thinking push to 3.10?
The effect on air density is fairly small.
Edit: We could just change all extension calls to use
100 * EGVAR(weather,currentHumidity)to avoid having to recompile? Effect would be the same.