Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeus Suppression Module #4977

Merged
merged 11 commits into from
May 10, 2017
Merged

Zeus Suppression Module #4977

merged 11 commits into from
May 10, 2017

Conversation

bux
Copy link
Member

@bux bux commented Mar 8, 2017

When merged this pull request will:

  • Add a module that will allow a zeus to direct suppression fire to certain location / unit

@PabstMirror did all the real work

click to enlarge

@bux bux added kind/enhancement Release Notes: **IMPROVED:** status/WIP labels Mar 8, 2017
@bux bux added this to the 3.9.1 milestone Mar 8, 2017
@bux
Copy link
Member Author

bux commented Mar 8, 2017

I guess the only thing that's left, is to disable the line of sight check for indirect fire units (mortars / artillery

Copy link
Contributor

@thojkooi thojkooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed some formatting issues - lgtm otherwise.

} else {
(vehicle _unit) doArtilleryFire [ASLtoAGL _targetASL, _artilleryMag, 1]; // note, using value greater than 1 does not always work
TRACE_3("doArtilleryFire",_unit,_targetASL,_artilleryMag);
_this set [2, _nextRun + 7];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation is off for line 37 and line 33.

*/
#include "script_component.hpp"

#define
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty #define ?

@bux bux removed the status/WIP label Mar 10, 2017
@PabstMirror PabstMirror modified the milestones: 3.10.0, 3.9.1 Mar 12, 2017
@PabstMirror PabstMirror merged commit b3f03d5 into master May 10, 2017
@PabstMirror PabstMirror deleted the moduleDestination branch May 10, 2017 16:29
@kymckay
Copy link
Member

kymckay commented May 11, 2017

Just saw this for the first time, really elegant work with the module target selection @PabstMirror 👍 Extra happy you managed to generalize it so it can be used in other modules too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants