-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zeus Suppression Module #4977
Zeus Suppression Module #4977
Conversation
I guess the only thing that's left, is to disable the line of sight check for indirect fire units (mortars / artillery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed some formatting issues - lgtm otherwise.
} else { | ||
(vehicle _unit) doArtilleryFire [ASLtoAGL _targetASL, _artilleryMag, 1]; // note, using value greater than 1 does not always work | ||
TRACE_3("doArtilleryFire",_unit,_targetASL,_artilleryMag); | ||
_this set [2, _nextRun + 7]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation is off for line 37 and line 33.
*/ | ||
#include "script_component.hpp" | ||
|
||
#define |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty #define
?
Just saw this for the first time, really elegant work with the module target selection @PabstMirror 👍 Extra happy you managed to generalize it so it can be used in other modules too |
When merged this pull request will:
@PabstMirror did all the real work
click to enlarge