Fix Zeus teleport players module #5175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the message about the module having no function when in SP.
BI made a change to the function this module was using. So now it has to be ran local to the player in question.
Neviothr
reviewed
May 26, 2017
| private _attached = attachedTo _logic; | ||
| if (isNull _attached) then { | ||
| [QGVAR(moveToRespawnPosition), [_x, getPos _logic], _x] call CBA_fnc_targetEvent; | ||
| // Function takes position AGL and must be ran where local | ||
| [QGVAR(moveToRespawnPosition), [_x, _logic modelToWorld [0,0,0]], _x] call CBA_fnc_targetEvent; |
There was a problem hiding this comment.
Spaces after , in modelToWorld? [0,0,0] -> [0, 0, 0].
There was a problem hiding this comment.
I'm not sure if we have a set standard for that, but personally I only use spaces where it helps with readability. In this case I'd argue that adding spaces actually has the opposite effect.
PabstMirror
approved these changes
May 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: