Interaction - Add actions based on animations #6144

Dystopian · 2018-02-11T00:37:11Z

When merged this pull request will:

add animation based actions framework;
add Take off action to:
- backpacks on Offroad and some armored vehicles (since 1.82);
- spare wheel on Wrangler and Van;
- spare wheel on RHS AFRF cars (UAZ, Ural, KamAZ, Tigr, GAZ-66, ZIL-131) and BTRs;
- spare wheel on RHS USF trucks (FMTV and HEMMT);
- spare tracks on Kamysh and Tigris;
- fuel canisters on Marid and arty;
- entrench tool on some armored vehicles (since 1.82);
disable RHS AFRF vehicles Retread system ~~(except BTRs which is not so simple)~~.

Some vehicles have animations which could be useful for in-game interaction. At first I thought to add all possible animations like remove doors and some vehicle parts. But then I decided to stop on really useful animations which can give you spare wheel e.g.

Animation based actions Framework allows to use any vehicle animations, which can give some items or not. I tried to make it universal enough but not too overloaded with all possible parameters. It can be easily used in 3rd party mods because it's based on configs and not on code.

Any ideas about other useful animations are welcomed.

If this PR is merged I'll add documentation in another PR.

Also at least CUP has Datsun with animated spare wheel.

Testing missions with modified vehicles:
ace_interaction_anims.VR.zip
ace_interaction_anims_RHS.VR.zip

jonpas · 2018-02-11T01:37:33Z

Neat!

I think some more API allowing disabling of such actions (a setting maybe) would be good. Additionally also setting items[] array via SQF in addition to config, so mission makers can set different types of eg. backpacks on offroads.

Those animated parts, aren't they just proxies? In that case it should be possible to get their location programmatically maybe?

Dystopian · 2018-02-11T08:42:14Z

I think some more API allowing disabling of such actions (a setting maybe) would be good.

You want settings for each feature :) User can easily disable such actions with switching these anims to disabled state (even in editor via Vehicle Customization). So I don't think another setting is really needed.

Additionally also setting items[] array via SQF in addition to config, so mission makers can set different types of eg. backpacks on offroads.

Can't imagine any real use cases for that. Only some vehicles have working anims and only few of them are really useful. Please don't think I try to avoid additional coding, I just need to know if it worth it.
I didn't add any user API exactly because of that.

Those animated parts, aren't they just proxies? In that case it should be possible to get their location programmatically maybe?

I don't understand about proxies. Some anims have config values source = "Proxy" but I don't know how to use this info. Some vehicles have named selections in appropriate places (Wrangler) and it's much easier; some have them too dislodged (Van) and some don't have any (Offroad) - so you have to use absolute position.

jonpas · 2018-02-11T12:43:02Z

Toggling one setting is a lot faster than disabling animations on all the vehicles.

API is probably not worth it, but I was already seeing possibilities for future, ability to put those items back on trucks and so on. :D

Add actions for backpacks, canisters, entrench tool. Move items and backpack to WeaponHolder.

Dystopian · 2018-04-22T21:32:35Z

1.82 brought some new animations so I added more backpacks and fuel canisters, spare tracks, entrench tool.
Also now backpacks and items go to WeaponHolder not to own vehicle.

Still not sure about hybrid config entries (which can be string or array) - it's not so good for mods.

addons/interaction/functions/fnc_switchAnimActions.sqf

Dystopian · 2018-09-20T02:49:52Z

Another time merged with master. Also found a way to disable RHS retread on BTRs.

Dystopian · 2018-09-23T15:26:46Z

Is it a good idea to move anim configs to subfolder because they are independent enough (at least in interaction module)?

addons/interaction/functions/fnc_switchAnimActions.sqf

Dystopian · 2020-03-17T19:10:18Z

Found CUP anims: Datsun, RG31, UAZ (spare wheel); Land Rover (spare wheels, jerrycans, Entrenching Tool, wire cutter (what?)). Can't start implement them if this PR is not merged.

jonpas · 2021-04-20T21:07:53Z

Still not sure about hybrid config entries (which can be string or array) - it's not so good for mods.

Make it just array, it can be array with one item.

Is it a good idea to move anim configs to subfolder because they are independent enough (at least in interaction module)?

Could do that but you will quickly run into issues with base classes, eg. where multiple files reference same base class, it just goes all over the place.

addons/interaction/functions/fnc_initAnimActions.sqf

- Made anim setting require a mission restart - Handle more types of items that can be spawned - Prioritise adding items to inventory and only drop on ground if no inventory space - Add more position checks to make certain no valid position are present before stopping - If 1 item was spawned in, it's considered as success - Disable RHS' wheel replacement only if ace_repair is loaded

johnb432

LGTM, but given I've redone some of the code, having another person take a look would be good.

… to some missing vehicles

johnb432 · 2024-08-09T18:02:41Z

Sorry to add this many changes, but I felt they were necessary:

Added option to give the progress bar a title
Used better names & progress bar titles than the default
Added some missing interactions (rhs_kraz255b1_base's spare wheel, 2x base game HEMTTs' spare wheel)
Restructured compats, so that interactions load only if the dependencies are there
Improved interaction positions on turrets (previously some of them were static and didn't follow the turret, now they do)

addons/compat_rhs_afrf3/compat_rhs_afrf3_repair/CfgEventHandlers.hpp

* Add actions based on animations * Add setting * Add ability to set items for users * Add actions for 1.82 changes Add actions for backpacks, canisters, entrench tool. Move items and backpack to WeaponHolder. * Add RHS 0.4.6 ZIL spare * Update to new standards * Handle RHS BTR retread system * Make init faster: move condition to configClasses * Fix CUP fake anims * Refactor * Rework * Rename init function * Decrease number of classes to init * Fix merge mistake * Apply suggestions from code review * Updated code for current mod structure * Multiple fixes & tweaks - Made anim setting require a mission restart - Handle more types of items that can be spawned - Prioritise adding items to inventory and only drop on ground if no inventory space - Add more position checks to make certain no valid position are present before stopping - If 1 item was spawned in, it's considered as success - Disable RHS' wheel replacement only if ace_repair is loaded * Update CfgVehicles.hpp * cache config lookup at preStart * Fix error * Add text config entry for progress bar title * Restructure interactions, improved some locations & added interaction to some missing vehicles * Reverted preInit change --------- Co-authored-by: jonpas <jonpas33@gmail.com> Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> Co-authored-by: PabstMirror <pabstmirror@gmail.com>

Add actions based on animations

c9cdf70

jonpas added kind/feature Release Notes: **ADDED:** status/review-pending labels Feb 11, 2018

Dystopian added 4 commits February 12, 2018 12:32

Add setting

019417a

Add ability to set items for users

eecc496

Merge remote-tracking branch 'upstream/master' into anim_actions

0803c32

Add actions for 1.82 changes

1e336e0

Add actions for backpacks, canisters, entrench tool. Move items and backpack to WeaponHolder.

Dystopian added 2 commits August 15, 2018 00:42

Merge remote-tracking branch 'upstream/master' into anim_actions

982705c

Add RHS 0.4.6 ZIL spare

a9067c5

Dystopian commented Aug 14, 2018

View reviewed changes

addons/interaction/functions/fnc_switchAnimActions.sqf Outdated Show resolved Hide resolved

Dystopian added 3 commits September 19, 2018 20:40

Merge remote-tracking branch 'upstream/master' into anim_actions

0fa0f1f

Update to new standards

70d7c9e

Handle RHS BTR retread system

5c2ced1

Dystopian added 2 commits September 23, 2018 16:12

Make init faster: move condition to configClasses

30dfa0e

Fix CUP fake anims

bc7a2e4

dedmen reviewed Sep 24, 2018

View reviewed changes

addons/interaction/functions/fnc_switchAnimActions.sqf Outdated Show resolved Hide resolved

Dystopian mentioned this pull request Oct 24, 2018

Changed/Updated isTurnedOut/isAttenuated function CBATeam/CBA_A3#1015

Closed

Dystopian added 2 commits December 9, 2018 19:25

Merge remote-tracking branch 'upstream/master' into anim_actions

2711901

Merge branch 'my2' into anim_actions

36c6846

jonpas added this to the 3.14.0 milestone Apr 20, 2021

Dystopian added 2 commits April 23, 2021 00:53

Merge remote-tracking branch 'upstream/master' into anim_actions

b9c73ab

Refactor

d0f3aa5

PabstMirror added this to the Ongoing milestone Oct 12, 2021

veteran29 approved these changes Oct 12, 2021

View reviewed changes

addons/interaction/functions/fnc_initAnimActions.sqf Outdated Show resolved Hide resolved

addons/interaction/functions/fnc_initAnimActions.sqf Outdated Show resolved Hide resolved

jonpas and others added 4 commits October 13, 2021 01:57

Merge branch 'master' into anim_actions

25adfec

Merge branch 'master' into pr/6144

be26111

Updated code for current mod structure

f291fe1

johnb432 mentioned this pull request Jul 20, 2024

RHS Compats - Add common to loadorder #10133

Merged

Merge branch 'master' into pr/6144

b50119f

johnb432 approved these changes Jul 20, 2024

View reviewed changes

johnb432 modified the milestones: Ongoing, 3.18.0 Jul 20, 2024

johnb432 and others added 2 commits July 22, 2024 10:02

Update CfgVehicles.hpp

b160189

cache config lookup at preStart

2b0faa7

PabstMirror approved these changes Aug 9, 2024

View reviewed changes

johnb432 added 4 commits August 9, 2024 11:05

Merge branch 'master' into pr/6144

76937f9

Fix error

dd7df53

Add text config entry for progress bar title

dccb240

Restructure interactions, improved some locations & added interaction…

e36682a

… to some missing vehicles

PabstMirror reviewed Aug 9, 2024

View reviewed changes

addons/compat_rhs_afrf3/compat_rhs_afrf3_repair/CfgEventHandlers.hpp Outdated Show resolved Hide resolved

PabstMirror reviewed Aug 9, 2024

View reviewed changes

addons/compat_rhs_afrf3/compat_rhs_afrf3_repair/CfgEventHandlers.hpp Outdated Show resolved Hide resolved

Reverted preInit change

1d0aa16

PabstMirror merged commit 96f81f1 into acemod:master Aug 11, 2024
5 checks passed

Andx667 mentioned this pull request Aug 15, 2024

ACE3 Feature Requests #3594

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Interaction - Add actions based on animations #6144

Interaction - Add actions based on animations #6144

Dystopian commented Feb 11, 2018 •

edited

Loading

jonpas commented Feb 11, 2018 •

edited

Loading

Dystopian commented Feb 11, 2018

jonpas commented Feb 11, 2018

Dystopian commented Apr 22, 2018 •

edited

Loading

Dystopian commented Sep 20, 2018

Dystopian commented Sep 23, 2018

Dystopian commented Mar 17, 2020

jonpas commented Apr 20, 2021

johnb432 left a comment

johnb432 commented Aug 9, 2024

Interaction - Add actions based on animations #6144

Interaction - Add actions based on animations #6144

Conversation

Dystopian commented Feb 11, 2018 • edited Loading

jonpas commented Feb 11, 2018 • edited Loading

Dystopian commented Feb 11, 2018

jonpas commented Feb 11, 2018

Dystopian commented Apr 22, 2018 • edited Loading

Dystopian commented Sep 20, 2018

Dystopian commented Sep 23, 2018

Dystopian commented Mar 17, 2020

jonpas commented Apr 20, 2021

johnb432 left a comment

Choose a reason for hiding this comment

johnb432 commented Aug 9, 2024

Dystopian commented Feb 11, 2018 •

edited

Loading

jonpas commented Feb 11, 2018 •

edited

Loading

Dystopian commented Apr 22, 2018 •

edited

Loading