Quickmount - Default enable quick mount (empty keybind) and Move to CBA Settings

[jonpas]

When merged this pull request will:

• Close Enabling quick mount should be a one-step process #6516

Hotkey is unset by default, no reason to have a setting in that case as described in #6516.

@jameslkingsley review please.

[dedmen]

I'm not that other guy. But I still approve of this.

[Dystopian]

What if some server admin would like to disable this feature? I think jameslkingsley meant just enabling by default.

[jonpas]

But he also said that's a hacky fix. :D

[jameslkingsley]

Looks good to me 👍

[Dystopian]

I just think Quick Mount can be not appropriate for some milsim PvP games because it's cheating a little. Setting would be helpful in these cases.
BTW where is that jonpas who asked me to add setting for some features I implemented? ;)

[jonpas]

I don't know, not my feature, I'll do what others think is best.

[PabstMirror]

Could add a new setting called GVAR(allowed) that is global and default to true

[dedmen]

Shouldn't the config entries be removed after the setting was moved to CBA?

[jonpas]

movedToSQF = 1;
I don't remember, but this has something to do with something.

[PabstMirror]

ace_common preinit runs first
if someone has a modified ace_settings in either mission config or configFile, the settings converted would think it was just an unconverted setting and try to add it first

[PabstMirror]

[localize ELSTRING(common,Enabled), localize LSTRING(KeybindDescription)],
not sure if description removed intentionally,
it wasn't a perfect match, but I thought it gave some context to what the module did

[Dystopian]

LLSTRING and LELSTRING could be used here and anywhere

[commy2]

Could simply delete the localize , because the settings system can translate the strings on its own.

[Dystopian]

btw just checked, subcategory is not automatically localized

[commy2]

Issue report then.

[PabstMirror]

fixed in CBATeam/CBA_A3#1003