-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add magazines with different tracer colors for some vanilla weapons #6658
Conversation
cool, I like seeing more ace tracer stuff! |
Thanks for the suggestion, I added this to the ToDo list |
Not WIP anymore. I would like to have this merged and work on UI later. Is dependend on next CBA release because of magazine wells. |
Any news here? |
Should probably add to both CBA and Vanilla magwells. |
Added magazines to Vanilla MagazineWells as well. |
optionals/tracers/stringtable.xml
Outdated
<English>.338 NM 130Rnd Belt Mixed (Green)</English> | ||
<German>.338 NM 130 Schuss Gurt gemischt (grün)</German> | ||
</Key> | ||
<Key ID="STR_ACE_Tracers_130Rnd_338_Mag_green_description"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are duplicates of vanilla string
<Key ID="str_a3_cfgmagazines_130rnd_338_mag1">
<Original>Caliber: .338 Norma Magnum<br />Rounds: 130<br />Used in: SPMG</Original>
I think we can just drop the description for all these and just use inheritance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 8711f42
// 5.56mm | ||
class 150Rnd_556x45_Drum_Mag_F; | ||
class ACE_150Rnd_556x45_Drum_green : 150Rnd_556x45_Drum_Mag_F { | ||
ammo = "B_556x45_Ball_tracer_green"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should also add
displaynameshort="$STR_A3_tracer_dns";
to all tracers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this is necessary. I checked Arma's config and all of the base classes I use have the correct displaynameshort configured, so it can be inherited.
…6658) * Add magazines for some vanilla weapons with different tracer colors * Removed obsolete comment * unified naming of tracer magazines * Add CfgMagazineWells * Add 5.8mm mags * Add Minimi boxes * Added 5.56 Drum mags * Add Katiba and 7.62x51 mags * Remove magazine macro to make config easier to read and edit. * Add pictures available in arma files * Add magazines to vanilla magazinWells * Fix wrong base class for Katiba tracer mags * Removed duplicate strings * delete blank lines in stringtable
When merged this pull request will:
Adds the following magazines:
All Magazines are added to the same CBA & Vanilla Magazine Wells as their vanilla base classes.