Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+= for magwells #6974

Merged
merged 1 commit into from
May 3, 2019
Merged

+= for magwells #6974

merged 1 commit into from
May 3, 2019

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented May 3, 2019

When merged this pull request will:

@commy2 commy2 added the kind/bug-fix Release Notes: **FIXED:** label May 3, 2019
@commy2 commy2 added this to the 3.12.7 milestone May 3, 2019
@commy2 commy2 self-assigned this May 3, 2019
PabstMirror
PabstMirror approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels weird doing += to an array that's not defined
but I tested this as working

@commy2
Copy link
Contributor Author

commy2 commented May 3, 2019

feels weird doing += to an array that's not defined

You have to, otherwise you run into issues with loading order.

@commy2 commy2 merged commit 36688ac into master May 3, 2019
@commy2 commy2 deleted the plusequal-magwells branch May 3, 2019 14:46
@Blutze Blutze mentioned this pull request May 16, 2019
Closed
@PabstMirror PabstMirror modified the milestones: 3.12.7, 3.13.0 Jul 5, 2019
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@commy2
Merge pull request #6974 from acemod/plusequal-magwells
5307838 
+= for magwells
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.13.0-temp2 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedmen dedmen dedmen approved these changes

@jonpas jonpas jonpas approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees

@commy2 commy2

Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.

Magazine proxies 1.92 compatibility
4 participants
@commy2 @dedmen @jonpas @PabstMirror