Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to HEMTT (User) #7292

Closed
wants to merge 1 commit into from
Closed

Adapt to HEMTT (User) #7292

wants to merge 1 commit into from

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented Dec 3, 2019

Continuation of #6900 for general use.

When merged this pull request will:

  • Add scripts (setup.bat and setup.sh) to download project-specific HEMTT binary

TODO ACE3:

TODO HEMTT:

@jonpas jonpas added this to the Ongoing milestone Dec 3, 2019
@jonpas jonpas mentioned this pull request Dec 3, 2019
13 tasks
ARCH=$(uname -m)

echo "=> Downloading HEMTT..."
wget -q --show-progress https://github.com/synixebrett/HEMTT/releases/download/v$VERSION/hemtt-v$VERSION-$ARCH-unknown-linux-gnu.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script will continue even if this fails. Add set -e somewhere before to exit the script if any command fails.

rm hemtt-v$VERSION-$ARCH-unknown-linux-gnu.tar.gz

echo "=> Updating HEMTT..."
../hemtt update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it really auto update? Future changes in HEMTT might not work with the current project setup such as hemtt.toml.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if I'll keep those scripts around at all yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A npm like update scheme might be good here? only update patches, but not minor?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to use a known working version and then update the HEMTT link once a newer version have been tested successfully.

@BrettMayson
Copy link
Member

Can this be closed with HEMTT 1.0.0 support already on master?

@jonpas
Copy link
Member Author

jonpas commented Mar 19, 2023

Yeah, although we should still update documentation and guide users to use HEMTT in the future.

@jonpas jonpas closed this Mar 19, 2023
@jonpas jonpas deleted the hemtt-user branch March 19, 2023 23:09
@LinkIsGrim LinkIsGrim removed this from the Ongoing milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants