-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to HEMTT (User) #7292
Adapt to HEMTT (User) #7292
Conversation
ARCH=$(uname -m) | ||
|
||
echo "=> Downloading HEMTT..." | ||
wget -q --show-progress https://github.com/synixebrett/HEMTT/releases/download/v$VERSION/hemtt-v$VERSION-$ARCH-unknown-linux-gnu.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script will continue even if this fails. Add set -e
somewhere before to exit the script if any command fails.
rm hemtt-v$VERSION-$ARCH-unknown-linux-gnu.tar.gz | ||
|
||
echo "=> Updating HEMTT..." | ||
../hemtt update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it really auto update? Future changes in HEMTT might not work with the current project setup such as hemtt.toml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if I'll keep those scripts around at all yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A npm like update scheme might be good here? only update patches, but not minor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to use a known working version and then update the HEMTT link once a newer version have been tested successfully.
Can this be closed with HEMTT 1.0.0 support already on master? |
Yeah, although we should still update documentation and guide users to use HEMTT in the future. |
Continuation of #6900 for general use.
When merged this pull request will:
setup.bat
andsetup.sh
) to download project-specific HEMTT binaryTODO ACE3:
TODO HEMTT:
make.py
orMakefile
) (Build Feature - Version Increment BrettMayson/HEMTT#16)