fix double execution of killed event

[commy2]

When merged this pull request will:

• I can't reproduce the error if I don't return values when the unit is dead.

Don't ask why this works.

[commy2]

Please test with:

["CAManBase", "Init", { 
    params ["_unit"]; 
 
    _unit addEventHandler ["Killed", { 
        systemChat str _this;
    }]; 
}, nil, nil, true] call CBA_fnc_addClassEventHandler; 

, because:

["CAManBase", "Killed", { 
    systemChat str _this;
}] call CBA_fnc_addClassEventHandler; 

is already covered by CBATeam/CBA_A3#1291

[jonpas]

Write a comment directly in the code, so it won't get cleaned up one day.

[commy2]

Done.

[PabstMirror]

Seems to report correct killer, will do mp testing soon

[mharis001]

_unit is nil in this scope.

[PabstMirror]

Sadly, this is what was making it "work", our EH always just returned nil; which meant the unit just died from vanilla medical.

[PabstMirror]

Still getting double killed EH

Mission [47792]: ace_medical_death event [id: 1] - [a2]
"calling setStructuralDamage (setDamage 1)"
Mission [47792]: ace_medical_woundReceived event [id: 1] - [a2,"Head",3.30751,a1,"B_65x39_Caseless",[0,3.30751,1,0,2,0.0232521,3,0.111614,4,0,5,0]]
Mission [47792]: ace_killed event [id: 0] - [a2,"FatalInjury:Death",a1,a1]
Mission [47792]: BIS addEventHandler killed [id: 1] - [a2,a2,<NULL-object>,true]
Mission [47792]: CBA addClassEventHandler killed [id: any] - [a2,a2,<NULL-object>,true] // using dev cba w/ double killed fix
Mission [47792]: BIS addEventHandler killed [id: 1] - [a2,a1,a1,true] // (modifyKilledArray disabled in handleDamage)

[commy2]

@PabstMirror What does it report with this?

[PabstMirror]

both of these caused double killed

private _return = _this call FUNC(handleDamage);
if (!alive param [0]) exitWith {diag_log "ret nil"; nil};
_return

private _return = _this call FUNC(handleDamage);
if (alive param [0]) then { _return } else {nil};