Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Add variable to block item replacement temporarily #9265

Merged
merged 8 commits into from
Jul 22, 2023

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Jul 14, 2023

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432
Copy link
Contributor

Should this be a status effect instead?

I'd say it's depends: Do you want this to be publicly available, so that other mods can get and set it?

Personally I'd think it would be nice for it to be a status effect.

@PabstMirror
Copy link
Contributor

9a704f9
any thoughts on just re-calling the replace code instead of the fake item

@LinkIsGrim
Copy link
Contributor Author

9a704f9 any thoughts on just re-calling the replace code instead of the fake item

Awesome. compileFinal to be safe though.

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jul 22, 2023
@PabstMirror PabstMirror added this to the 3.16.0 milestone Jul 22, 2023
@LinkIsGrim LinkIsGrim merged commit 35ce8d1 into acemod:master Jul 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fnc_registerItemReplacement have awkward behavior while in Arsenal
3 participants