Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KillTracker - Add option to filter out AI unit kills #9800

Merged
merged 8 commits into from
Feb 19, 2024
Merged

KillTracker - Add option to filter out AI unit kills #9800

merged 8 commits into from
Feb 19, 2024

Conversation

ilbinek
Copy link
Contributor

@ilbinek ilbinek commented Feb 16, 2024 •
edited by Mike-MF
Loading

When merged this pull request will:

  • Add an option to disable tracking of kills of AI units when using ACE Kill Tracker. Configurable through Addon Settings
  • CfgEventHandlers.cpp
    • Added PreInit to Extended Event Handlers
  • XEH_postInit.sqf
    • Added check if AI tracking is enabled and track AI kills only if so
  • XEH_preInit.sqf
    • Added call to init Addon Settings
  • initSettings.inc.sqf
    • Added the actual add settings call
  • stringtable.xml
    • Added necessary translations

@ilbinek
Add option to disable AI kills tracking in Kill Tracker
2181f1e 
Add an option to disable tracking of kills of AI units when using ACE Kill Tracker. Configurable through Addon Settings
johnb432
johnb432 requested changes Feb 16, 2024
View reviewed changes
addons/killtracker/CfgEventHandlers.hpp Outdated Show resolved Hide resolved
addons/killtracker/initSettings.inc.sqf Outdated Show resolved Hide resolved
addons/killtracker/initSettings.inc.sqf Outdated Show resolved Hide resolved
addons/killtracker/stringtable.xml Outdated Show resolved Hide resolved
addons/killtracker/stringtable.xml Outdated Show resolved Hide resolved
@ilbinek @veteran29
Omitted optional default params
328efcc 
Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
@ilbinek ilbinek requested a review from johnb432 February 16, 2024 17:11
ilbinek and others added 2 commits February 16, 2024 19:38
@ilbinek @johnb432
Added missing dot
e3078ed 
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@ilbinek
Added missing dot in Czech translation
ac9cbbe
LinkIsGrim
LinkIsGrim approved these changes Feb 17, 2024
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinkIsGrim LinkIsGrim added the kind/feature Release Notes: **ADDED:** label Feb 17, 2024
@LinkIsGrim LinkIsGrim added this to the 3.16.4 milestone Feb 17, 2024
@PabstMirror PabstMirror merged commit fd7a500 into acemod:master Feb 19, 2024
5 checks passed
@ilbinek ilbinek deleted the killtracker_ai_ignroe branch February 19, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veteran29 veteran29 veteran29 left review comments

@rautamiekka rautamiekka rautamiekka left review comments

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@johnb432 johnb432 johnb432 approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Milestone
3.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ilbinek @rautamiekka @veteran29 @PabstMirror @johnb432 @LinkIsGrim