Arsenal Stats - Add support for multiline text

[DartRuffian]

When merged this pull request will:

• Title

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

TODO

• Add support for returning array of data as stat text statement
• Resize stat controls based on text statement result
• Fix stat result text being slightly offset after switching to RscTextMulti

[LinkIsGrim]

You'll need to use ctrlTextHeight and ctrlSetPositionH liberally on the stats box/controls and offset the actions box accordingly (though the actions box can just have ctrlPositionY = ctrlPositionY statsBox + ctrlPositionH statsBox + offset, if it's not already exactly that).

[DartRuffian]

You'll need to use ctrlTextHeight and ctrlSetPositionH liberally on the stats box/controls and offset the actions box accordingly (though the actions box can just have ctrlPositionY = ctrlPositionY statsBox + ctrlPositionH statsBox + offset, if it's not already exactly that).

Alright, I'll try that out, thanks

[DartRuffian]

Something I noticed is that RscTextMulti seems to add some offset to the text, as its now no longer vertically centered with the bar.

[DartRuffian]

I added an idc for statsStaticBackground2 since I was needed one for the main background. It can be removed but I figured it wouldn't do any harm to just add one for both backgrounds.

[Walthzer]

Quickly threw something together, needs a bit of cleaning. Is this what you are trying to do?

[LinkIsGrim]

#9771 has a reference implementation if you need

[Walthzer]

Replaced row counting with control tracking as in #9771
Working on the phantom doubled bars rn.
Also arsenalActions defaults to row heights of (5 * GRID_H) but arsenalStats uses (4 * GRID_H)? 🤔

[Walthzer]

Been a long time since I last used git in a situation like this. How do I open a PR on DarkRuffians fork again? So he can import the changes to this PR. 🤦‍♂️

[LinkIsGrim]

Been a long time since I last used git in a situation like this. How do I open a PR on DarkRuffians fork again? So he can import the changes to this PR. 🤦‍♂️

Open a PR @ https://github.com/DartRuffian/ACE3/pulls and point to branch arsenal-multilineStats

[DartRuffian]

Thanks for helping with the PR
I was on and off on this for a while because I thought I'd make some progress and then hit a different block

[DartRuffian]

Not sure if you can mark it as ready (if it is), if not just let me know and I can mark it

[Walthzer]

Thanks for helping with the PR I was on and off on this for a while because I thought I'd make some progress and then hit a different block

Happy to help. UI is annoying to get into, but after you get the hang of it, its pretty straight forward. Actually spend more time trying to open a PR then making the changes. 😢

[Walthzer]

I can't mark it, but it should be ready.

[DartRuffian]

Happy to help. UI is annoying to get into, but after you get the hang of it, its pretty straight forward. Actually spend more time trying to open a PR then making the changes. 😢

I've messed with it before, most advanced thing I did was was just a basic bar that animated downwards based on a value.

[LinkIsGrim]

Just so HEMTT doesn't yell. Code LGTM, need to test (weekend).