Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Fix adding unusable throwables #9980

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Apr 28, 2024

When merged this pull request will:

  • FUNC(addToInventory) has been changed so that when you convert explosives using the CBA context menu, you don't have to drop them in order for you to use them. This change can be reverted once the bug in question (https://feedback.bistudio.com/T74244) has been addressed.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Apr 28, 2024
@johnb432 johnb432 marked this pull request as ready for review April 28, 2024 10:24
@johnb432 johnb432 changed the title Common - Prevent adding unusable throwables Common - Fix adding unusable throwables Apr 28, 2024
@johnb432 johnb432 added kind/bug-fix Release Notes: **FIXED:** and removed kind/enhancement Release Notes: **IMPROVED:** labels Apr 28, 2024
@PabstMirror
Copy link
Contributor

Just curious, what mods have throwables with count > 1?

@johnb432
Copy link
Contributor Author

Just curious, what mods have throwables with count > 1?

I have no idea, but I don't want to find out the hard way.

johnb432 and others added 2 commits April 29, 2024 00:38
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
@jonpas
Copy link
Member

jonpas commented Apr 29, 2024

3.17.1?

@jonpas jonpas added this to the 3.17.1 milestone Apr 29, 2024
@PabstMirror PabstMirror merged commit 4f1c2fa into master Apr 29, 2024
5 checks passed
@PabstMirror PabstMirror deleted the addToInventory-grenades-change branch April 29, 2024 17:13
@johnb432
Copy link
Contributor Author

Just curious, what mods have throwables with count > 1?

Fyi: SOG adds vn_v40_grenade_mag, which contains 3 grenades in 1 magazine.

johnb432 added a commit that referenced this pull request May 27, 2024
PabstMirror pushed a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants