Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools/get_dicom_files.pl] silently ignoring wrong id in resulting archive #954

Closed
regisoc opened this issue Apr 27, 2023 · 0 comments · Fixed by #995
Closed

[tools/get_dicom_files.pl] silently ignoring wrong id in resulting archive #954

regisoc opened this issue Apr 27, 2023 · 0 comments · Fixed by #995

Comments

@regisoc
Copy link
Contributor

regisoc commented Apr 27, 2023

Script tools/get_dicom_files.pl

When using the -id parameter, if it starts with something strictly different from what is expected, the result is what is expected.
But, if it starts with one of the expected ones (candid, pscid, candid_pscid or pscid_candid) and continues with something else (e.g. candidididiididi), the result is wrong = silent execution.

The problem is, since the id is wrong, it will not create the id level in the resulting archive.
The resulting file architecture should be id/visit_label/... but the erroneous one is only visit_label/....
For only one PatientName, the result is good enough, but it mixes several patients if multiple are present in the request.

# this does not work -> ok
perl tools/get_dicom_files.pl -name DCC090_587630_V1 -type dwi25 -outfile test -id nope -profile prod

# this works -> should not. `.tar.gz` created ignoring the ID folder, only visit folder.
perl tools/get_dicom_files.pl -name DCC090_587630_V1 -type dwi25 -outfile test -id candidididi -profile prod
perl tools/get_dicom_files.pl -name DCC090_587630_V1 -type dwi25 -outfile test -id pscidididi -profile prod

# One user + one type seems fine, but if multiple names that have the same visit => mixed in the same visit folder.
perl tools/get_dicom_files.pl -name DCC090_587630_V1,DCC292_676061_V1 -type t1 -outfile test -id candididi -profile prod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants