Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bids_import] Add single electrode value instead of all electrode values #1017

Merged

Conversation

jeffersoncasimir
Copy link
Contributor

This fixes a bug in electrode insertion, where more than one electrode was being inserted every time.

@christinerogers
Copy link
Collaborator

@jeffersoncasimir want to request a reviewer? maybe laetitia or regis review this, if it's straightforward
Mark it high priority for the next release if that makes sense too.

Copy link
Contributor

@regisoc regisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. If that is the case, lines containing electrode values (L371, L412) are not useful anymore and can be removed

@jeffersoncasimir
Copy link
Contributor Author

Good point. I just removed those two references.

Copy link
Contributor

@regisoc regisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 20 days.

@christinerogers
Copy link
Collaborator

christinerogers commented Feb 6, 2024

this PR is a High Priority Bug fix for the 26 release.

Let's get this merged.

@christinerogers christinerogers added Area: BIDS PR or issue related to the handling of BIDS datasets Area: EEG PR or issue related to EEG / iEEG processing labels Feb 6, 2024
@cmadjar cmadjar merged commit 574e25c into aces:main Feb 16, 2024
@cmadjar cmadjar added this to the 26.0.0 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: BIDS PR or issue related to the handling of BIDS datasets Area: EEG PR or issue related to EEG / iEEG processing Bug Priority: High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants