Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minc_insertion] Improve command line arguments validation #1123

Merged
merged 1 commit into from
May 30, 2024
Merged

[minc_insertion] Improve command line arguments validation #1123

merged 1 commit into from
May 30, 2024

Conversation

nicolasbrossard
Copy link
Collaborator

@nicolasbrossard nicolasbrossard commented May 6, 2024 •
edited
Loading

This PR improves the validation done on the command line parameters for script minc_insertion.pl. More specifically:

  • When the argument to -upload_id refers to a non-existent upload, the script displays a message indicating that the upload ID is invalid.
  • When the upload ID passed on the command line refers to an upload that does not have an associated tarchive (i.e value of TarchiveID for that upload is NULL in table mri_upload), an error message to that effect is displayed to the user.

@maximemulder maximemulder self-assigned this May 23, 2024
maximemulder
maximemulder approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@maximemulder maximemulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked on my end.

@cmadjar cmadjar added this to the 26.0.0 milestone May 30, 2024
@cmadjar cmadjar merged commit be0a93f into main May 30, 2024
2 checks passed
@cmadjar cmadjar linked an issue May 30, 2024 that may be closed by this pull request
uploadNeuroDB/minc_insertion.pl #1077
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximemulder maximemulder maximemulder approved these changes

Assignees

@maximemulder maximemulder

Labels
26.0-bug PassedManualTest Perl imaging pipeline
Projects
None yet
Milestone
26.0.0
Development

Successfully merging this pull request may close these issues.

uploadNeuroDB/minc_insertion.pl
4 participants
@nicolasbrossard @maximemulder @cmadjar @kongtiaowang