Integration test for run_dicom_archive_loader.py
#1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximemulder
added
the
A-CI
maximemulder
force-pushed
the
2024-10-18_integration-s3
branch
from
5586936
to
857053b
Compare
maximemulder
changed the title
maximemulder
force-pushed
the
2024-10-18_integration-s3
branch
from
857053b
to
b73ecff
Compare
maximemulder
changed the title
maximemulder
force-pushed
the
2024-10-18_integration-s3
branch
25 times, most recently
from
63dc912
to
25bd52d
Compare
maximemulder
force-pushed
the
2024-10-18_integration-s3
branch
8 times, most recently
from
f0c2278
to
dd3886c
Compare
maximemulder
changed the title
run_dicom_archive_loader.py
|
Still kind of barebones but better than nothing for now IMO. |
cmadjar
requested changes
Nov 12, 2024
.github/workflows/integration.yml
Outdated
Comment on lines
16
to
17
| BUCKET_ACCESS_KEY: lorisadmin-ro | ||
| BUCKET_SECRET_KEY: Tn=qP3LupmXnMuc |
There was a problem hiding this comment.
@maximemulder could this be secrets variables? I know this is for read-only data but still, not ideal to get credentials in the code.
There was a problem hiding this comment.
With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.
For variables:
https://github.com/orgs/community/discussions/44322
Variables are not passed to workflows that are triggered by a pull request from a fork.
It seems we cannot pass variable or secrets in pull requests triggered from a fork (i.e., all our PRs). I guess our choices are either:
- Make the variables secret, but the integration tests will need to be triggered manually.
- Hard-code the variables in the code (which makes them public), and the tests can be triggered automatically.
maximemulder
force-pushed
the
2024-10-18_integration-s3
branch
2 times, most recently
from
4535a88
to
ac4dcf7
Compare
maximemulder
force-pushed
the
2024-10-18_integration-s3
branch
7 times, most recently
from
2ab4bd1
to
0444bdb
Compare
maximemulder
force-pushed
the
2024-10-18_integration-s3
branch
from
0444bdb
to
fdd105f
Compare
|
There is now a test to check that a file has indeed been inserted in the database ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mounts the S3 bucket in CI and adds an integration test for
run_dicom_archive_loader.py!