Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to back-populate existing projects for SNR and AcqOrderPerModality: Redmine 11284 #162

Merged

Conversation

MounaSafiHarab
Copy link
Contributor

@MounaSafiHarab MounaSafiHarab commented Oct 13, 2016

tools/BackPopulateSNRAndAcquisitionOrder.pl -profile prod -tarchive_id 59 (for only this specific tarchive with tarchive_id = 59 in this example)

OR

tools/BackPopulateSNRAndAcquisitionOrder.pl -profile prod (for all tarchives in the tarchive table)

@cmadjar
Copy link
Collaborator

cmadjar commented Oct 17, 2016

I get a Can't locate object method "orderModalitiesByAcq" error message. Maybe you need to rebase the branch with the latest aces/17.0-dev branch?

@MounaSafiHarab
Copy link
Contributor Author

@cmadjar

yes, in the conversation I say it was awaiting #160 to be merged.
do you want me to rebase this pull request?

@MounaSafiHarab
Copy link
Contributor Author

@cmadjar
I did rebase (I think and hope I did!); let me know otherwise!

@cmadjar
Copy link
Collaborator

cmadjar commented Oct 17, 2016

Great! Thanks!!

@gluneau
Copy link
Contributor

gluneau commented Oct 19, 2016

Please check so that if SNR function does not return anything, don't insert.

@MounaSafiHarab
Copy link
Contributor Author

@gluneau
I will look into this, thanks Greg.
Thanks for bringing this up as well (this is to be used AFTER this has been merged:
#153) to avoid the msql errors on duplicate

@MounaSafiHarab
Copy link
Contributor Author

MounaSafiHarab commented Oct 20, 2016

@gluneau

done!
the latest commit here:
697df08
takes care of your comment (if $SNR ne ' ' ... only then do we setParameter)

@christinerogers
Copy link
Collaborator

christinerogers commented Oct 21, 2016

Add context to the top line of this Pull Request blurb at top - e.g.
This is a script to be run by existing projects upgrading to 17.0.
It should be run after you have applied the release patch -specifically containing table updates from PRs ____ and ___ ...
@MounaSafiHarab

@samirdas samirdas merged commit 49aa24b into aces:17.0-dev Oct 21, 2016
@MounaSafiHarab MounaSafiHarab changed the title Script to back-populate existing projects for SNR and AcqOrderPerModality Script to back-populate existing projects for SNR and AcqOrderPerModality: Redmine 11284 Oct 21, 2016
@MounaSafiHarab
Copy link
Contributor Author

@christinerogers

your comment was taken into account and the conversation updated at the top of this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants