Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When tarchiveID exists, instruct the user how to launch tarchiveLoader at the command line: Redmine 11157 #165

Merged

Conversation

MounaSafiHarab
Copy link
Contributor

As discussed in the imaging meeting, the user is now told what command to run to launch tarchiveLoader if the tarchiveID already exists (i.e. dicomTar.pl has completed).

@MounaSafiHarab MounaSafiHarab added this to the 17.0 milestone Oct 14, 2016
@MounaSafiHarab MounaSafiHarab changed the title When tarchiveID exists, instructs the user how to launch tarchiveLoader at the command line: Redmine 11157 When tarchiveID exists, instruct the user how to launch tarchiveLoader at the command line: Redmine 11157 Oct 17, 2016
@gluneau
Copy link
Contributor

gluneau commented Oct 25, 2016

It works like it should:

imaging_upload_file.pl -profile prod -verbose -upload_id 371 /tmp/JedZFk/SEA1042_152174_V24.zip  

Spool message is: 
The Scan for the uploadID 371 has already been ran with tarchiveID: 5000184. 
To continue with the rest of the insertion pipeline, please run tarchiveLoader from a terminal as follows: /data/ibis/bin/mri/uploadNeuroDB/tarchiveLoader -globLocation -profile prod /data/ibis/data/tarchive/2016/DCM_2016-08-13_ImagingUpload-15-16-u7PhbY.tar -verbose


The candidate info validation has failed

@christinerogers
Copy link
Collaborator

Looks great! I noticed a small typo: "has already been ran with" (ran->run).

Would it help to specify how the candidate info validation failed - the nature of the error?

@MounaSafiHarab
Copy link
Contributor Author

@christinerogers

typo fixed; thanks a lot in the second commit :)
as to the message, I think it is self explanatory: when we validate candidate we do:

  1. tarchive not run before
  2. files are all type dicom
  3. patient name in mri_upload matches dicom header

any of the errors above will cause the candidate info validation to fail. In this case, it is step 1) that failed which is why you get both messages (that tarchive has been run and therefore the candidate info validation has failed).

@MounaSafiHarab MounaSafiHarab merged commit 02bf216 into aces:17.0-dev Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants