Removing PendingStaging field from the files table #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasbrossard
requested changes
Apr 9, 2018
There was a problem hiding this comment.
Minor nitpick regarding the perldoc of the getSessionID method in MRI.pm: mentions of the $noStagingCheck feature should be removed from the general description and the 'returns' section should say that the returned list contains one element (not two). Apart from that, all good. 👍
|
@nicolasbrossard Good catch! I updated the description of the getSessionID function. Ready for another round of review or for approval ;) |
nicolasbrossard
approved these changes
Apr 16, 2018
cmadjar
force-pushed
the
RemovingPendingStagingFromFiles
branch
3 times, most recently
from
8b27fc5
to
d31f4f0
Compare
Removed all occurences of requiresStaging in the code Updated the documentation of getSessionID of MRI.pm update MRI.md
cmadjar
force-pushed
the
RemovingPendingStagingFromFiles
branch
from
d31f4f0
to
258234d
Compare
driusan
pushed a commit
to aces/Loris
that referenced
this pull request
Aug 27, 2018
This removes the unused PendingStaging field from the files table as was discussed during the LORIS imaging meeting of February 2nd, 2018.
See also:
associated redmine ticket: https://redmine.cbrain.mcgill.ca/issues/13876
associate PR on the LORIS-MRI side: aces/Loris-MRI#292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the unused PendingStaging field from the files table as was discussed during the LORIS imaging meeting of February 2nd, 2018.
See also:
Note for reviewers:
I removed all the code associated to this PendingStaging field. I checked IBIS and PREVENT-AD, this field is always filled with 0. Maybe you could check your DB just to be sure but at this point, I am fairly confident this is not used.