-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 24.1.7 into main #879
Commits on Nov 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f471c59 - Browse repository at this point
Copy the full SHA f471c59View commit details -
[dcm2bids] Remove hardcoded dcm2niix binary to use the value stored i…
…n the `converter` Config setting (aces#815) * modifies the dcm2niix command to use the Config converter value instead of hardcoding dcm2niix * add a check to make sure the converter is a dcm2niix binary
Configuration menu - View commit details
-
Copy full SHA for 90e7a9a - Browse repository at this point
Copy the full SHA 90e7a9aView commit details -
Pull 24.0.3 in 24.1 release (aces#820)
* Reload the mri_upload dictionary before checking if a tarchive has been validated (aces#783) * reload mri_upload object * remove debugging exit and print statements * fix minor bugs when dealing with scans.tsv files (aces#774) * fix regex search for excluded series description patterns (aces#786) * fix_return_statement_of_create_imaging_upload_dict_from_upload_id_function (aces#787) * [dcm2bids] Insert into MRICandidateErrors if there is a Candidate PatientName mismatch (aces#790) * insert into MRICandidateErrors when candidate mismatch or pname not matching between DICOMs and NIfTI * remove exit * fix table name to MRICandidateErrors instead of MriCandidateErrors as apparently, it makes a difference on MariaDB/Linux VMs while it just worked on local install on Mac... (aces#793) * Set DICOM dates to undef if the date does not follow proper DICOM standard (aces#794) * set date to undef if it does not follow proper DICOM formats * fix all dates set to NULL * Installation and pet fixes (aces#818) Co-authored-by: Laetitia Fesselier <laetitia.fesselier@mcgill.ca> * Update VERSION file for next bug fix release Co-authored-by: Laetitia Fesselier <laetitia.fesselier@mail.mcgill.ca> Co-authored-by: Laetitia Fesselier <laetitia.fesselier@mcgill.ca>
Configuration menu - View commit details
-
Copy full SHA for 02333c9 - Browse repository at this point
Copy the full SHA 02333c9View commit details
Commits on Nov 7, 2022
-
fix nonetype errors when the visit of a session does not exist so tha…
…t proper logging is done (aces#824)
Configuration menu - View commit details
-
Copy full SHA for 0614e8c - Browse repository at this point
Copy the full SHA 0614e8cView commit details
Commits on Nov 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f47421d - Browse repository at this point
Copy the full SHA f47421dView commit details -
Add capability to download file from s3 (aces#826)
* add capability to download file from s3 * fix flake8 error
Configuration menu - View commit details
-
Copy full SHA for f0810cb - Browse repository at this point
Copy the full SHA f0810cbView commit details -
Upload to S3: support object name starting with s3://bucket_name/ for…
… upload (aces#827) * add capability to download file from s3 * fix flake8 error * add ability to remove s3://bucketname/ from the object name before upload
Configuration menu - View commit details
-
Copy full SHA for 3644f95 - Browse repository at this point
Copy the full SHA 3644f95View commit details
Commits on Nov 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 55c0d8c - Browse repository at this point
Copy the full SHA 55c0d8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34e8041 - Browse repository at this point
Copy the full SHA 34e8041View commit details -
modify permission of script run_push_imaging_files_to_s3_pipeline.py …
…to make it executable (aces#830)
Configuration menu - View commit details
-
Copy full SHA for 47c797e - Browse repository at this point
Copy the full SHA 47c797eView commit details
Commits on Nov 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 02507c5 - Browse repository at this point
Copy the full SHA 02507c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c376bb - Browse repository at this point
Copy the full SHA 9c376bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e62ea82 - Browse repository at this point
Copy the full SHA e62ea82View commit details
Commits on Nov 14, 2022
-
fix violation files path when checking if the files are on the filesy…
…stem before adding them to the list of files to push to S3 (aces#834)
Configuration menu - View commit details
-
Copy full SHA for 0d27d49 - Browse repository at this point
Copy the full SHA 0d27d49View commit details -
Merge 24.0 release into 24.1 release (aces#836)
* Reload the mri_upload dictionary before checking if a tarchive has been validated (aces#783) * reload mri_upload object * remove debugging exit and print statements * fix minor bugs when dealing with scans.tsv files (aces#774) * fix regex search for excluded series description patterns (aces#786) * fix_return_statement_of_create_imaging_upload_dict_from_upload_id_function (aces#787) * [dcm2bids] Insert into MRICandidateErrors if there is a Candidate PatientName mismatch (aces#790) * insert into MRICandidateErrors when candidate mismatch or pname not matching between DICOMs and NIfTI * remove exit * fix table name to MRICandidateErrors instead of MriCandidateErrors as apparently, it makes a difference on MariaDB/Linux VMs while it just worked on local install on Mac... (aces#793) * Set DICOM dates to undef if the date does not follow proper DICOM standard (aces#794) * set date to undef if it does not follow proper DICOM formats * fix all dates set to NULL * Installation and pet fixes (aces#818) Co-authored-by: Laetitia Fesselier <laetitia.fesselier@mcgill.ca> * Update VERSION file for next bug fix release * Project, event validation and protobuf update (aces#823) * Project, event validation and protobuf update * Site and project search when creating candidate * missing import * correct pscid search * Events validation * flake rules update * review, and NULL value filtered out for site and project * flake * flake Co-authored-by: regisoc <regis.ongaro-carcy@mcin.ca> * fix conflict * fix version * fix version Co-authored-by: Laetitia Fesselier <laetitia.fesselier@mail.mcgill.ca> Co-authored-by: Laetitia Fesselier <laetitia.fesselier@mcgill.ca> Co-authored-by: regisoc <regis.ongaro-carcy@mcin.ca>
Configuration menu - View commit details
-
Copy full SHA for 4fd75e2 - Browse repository at this point
Copy the full SHA 4fd75e2View commit details
Commits on Dec 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a826be3 - Browse repository at this point
Copy the full SHA a826be3View commit details -
Fix logic of determining file run number when previously inserted fil…
…es are already pushed to S3 and not on filesystem anymore (aces#846) * fix bug * fix listing of filenames * comment new function
Configuration menu - View commit details
-
Copy full SHA for c9afaa2 - Browse repository at this point
Copy the full SHA c9afaa2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17f6652 - Browse repository at this point
Copy the full SHA 17f6652View commit details -
Chunk creation subprocess failure check (aces#848)
* Chunk creation subprocess failure check Raise error when the chunk creation subprocess fails. Fix aces#843 * Update python/lib/physiological.py Print actual error message Co-authored-by: Cécile Madjar <cecile.madjar@mcin.ca> Co-authored-by: Cécile Madjar <cecile.madjar@mcin.ca>
Configuration menu - View commit details
-
Copy full SHA for b224835 - Browse repository at this point
Copy the full SHA b224835View commit details -
Configuration menu - View commit details
-
Copy full SHA for afe6903 - Browse repository at this point
Copy the full SHA afe6903View commit details
Commits on Dec 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cef8f87 - Browse repository at this point
Copy the full SHA cef8f87View commit details
Commits on Dec 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3af8cf6 - Browse repository at this point
Copy the full SHA 3af8cf6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 115283e - Browse repository at this point
Copy the full SHA 115283eView commit details
Commits on Dec 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e8103e7 - Browse repository at this point
Copy the full SHA e8103e7View commit details
Commits on Dec 21, 2022
-
Add missing exit codes on the python's side (aces#857)
* add some missing exit codes * add some missing exit codes
Configuration menu - View commit details
-
Copy full SHA for 049414e - Browse repository at this point
Copy the full SHA 049414eView commit details
Commits on Dec 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 27f7e63 - Browse repository at this point
Copy the full SHA 27f7e63View commit details
Commits on Jan 4, 2023
-
add download from S3 and reupload if file provided to run_nifti-inser…
…tion was an S3 URL (aces#860)
Configuration menu - View commit details
-
Copy full SHA for bd74369 - Browse repository at this point
Copy the full SHA bd74369View commit details
Commits on Jan 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a1dc483 - Browse repository at this point
Copy the full SHA a1dc483View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc00fd6 - Browse repository at this point
Copy the full SHA bc00fd6View commit details
Commits on Jan 12, 2023
-
fix paths when there are not / at the end of the Config (aces#866)
Tested on sandbox with Config `data_dir` = `/data/loris/data`
Configuration menu - View commit details
-
Copy full SHA for 82c47b8 - Browse repository at this point
Copy the full SHA 82c47b8View commit details -
fix NoneType error /opt/loris/bin/mri/python/lib/dcm2bids_imaging_pip…
…eline_lib/dicom_archive_loader_pipeline.py, line 346, in _add_intended_for_to_fieldmap_json_files (aces#867) Tested on HBCD sandbox on the dataset that caused the issue.
Configuration menu - View commit details
-
Copy full SHA for e77d767 - Browse repository at this point
Copy the full SHA e77d767View commit details
Commits on Jan 13, 2023
-
Properly update
mri_upload
'Inserting' column when different sectio……ns of the pipeline are run (aces#868) * update mri_upload to inserting=0 when push to s3 pipeline is finished * fix Inserting flag being properly set when pipeline is running
Configuration menu - View commit details
-
Copy full SHA for 9f986c8 - Browse repository at this point
Copy the full SHA 9f986c8View commit details
Commits on Jan 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d53b0a7 - Browse repository at this point
Copy the full SHA d53b0a7View commit details
Commits on Jan 24, 2023
-
Add download from S3 for fmap already pushed to S3 that needs to have…
… IntendedFor written in them (aces#874) * add download from S3 for fmap that needs to have IntendedFor written in them * add print
Configuration menu - View commit details
-
Copy full SHA for 0bda1a1 - Browse repository at this point
Copy the full SHA 0bda1a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fd8b48 - Browse repository at this point
Copy the full SHA 4fd8b48View commit details -
Merge 24.0.4 into 24.1 release (aces#878)
* Reload the mri_upload dictionary before checking if a tarchive has been validated (aces#783) * reload mri_upload object * remove debugging exit and print statements * fix minor bugs when dealing with scans.tsv files (aces#774) * fix regex search for excluded series description patterns (aces#786) * fix_return_statement_of_create_imaging_upload_dict_from_upload_id_function (aces#787) * [dcm2bids] Insert into MRICandidateErrors if there is a Candidate PatientName mismatch (aces#790) * insert into MRICandidateErrors when candidate mismatch or pname not matching between DICOMs and NIfTI * remove exit * fix table name to MRICandidateErrors instead of MriCandidateErrors as apparently, it makes a difference on MariaDB/Linux VMs while it just worked on local install on Mac... (aces#793) * Set DICOM dates to undef if the date does not follow proper DICOM standard (aces#794) * set date to undef if it does not follow proper DICOM formats * fix all dates set to NULL * Installation and pet fixes (aces#818) Co-authored-by: Laetitia Fesselier <laetitia.fesselier@mcgill.ca> * Update VERSION file for next bug fix release * Project, event validation and protobuf update (aces#823) * Project, event validation and protobuf update * Site and project search when creating candidate * missing import * correct pscid search * Events validation * flake rules update * review, and NULL value filtered out for site and project * flake * flake Co-authored-by: regisoc <regis.ongaro-carcy@mcin.ca> * DICOM Archive broken archive link fix (aces#872) * update version to 24.0.4 (aces#877) Co-authored-by: Laetitia Fesselier <laetitia.fesselier@mail.mcgill.ca> Co-authored-by: Laetitia Fesselier <laetitia.fesselier@mcgill.ca> Co-authored-by: regisoc <regis.ongaro-carcy@mcin.ca>
Configuration menu - View commit details
-
Copy full SHA for ca19cc4 - Browse repository at this point
Copy the full SHA ca19cc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a28c9b - Browse repository at this point
Copy the full SHA 4a28c9bView commit details