[Perl pipeline] Do not duplicate violation entry if it already exists #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check if entry already in mri_protocol_violated_scans handle mri_violations_log duplicate forgot to import MriViolationsLogOB in MRIProcessingUtility fix bug where file was moved when it should not have translate if else statement into perl... forgot Echotime when inserting into mri_violations_log commit markdown files
cmadjar
force-pushed
the
do_not_duplicate_violation_if_already_exists_perl
branch
from
70746c4
to
238d07b
Compare
nicolasbrossard
requested changes
Mar 6, 2023
See aces/Loris#8382. However, I have an issue with adding a key for the mri_violations_log table. See here: aces/Loris#8382 (comment). I have no idea how to resolve this... Also added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the
tarchiveLoader.plscript is rerun, it checks whether the file has already been registered into thefilestable before inserting a new entry in thefilestable but the pipeline does not check whether a violation has already been registered into the 3 violation tables (MRICandidateErrors,mri_protocol_violated_scansandmri_violations_log) and inserts duplicates of the same violation as many times astarchiveLoader.plis run on a DICOM archive.This was fixed on the python side by #884 and #891. This PR fixes this for the Perl side as well using the same algorithm.
Reminder: a unique file entry is now determined by the unique combination of
SeriesUID,EchoTime,PhaseEncodingDirectionandEchoNumbers.Resolves #890 as this is the only missing piece to close the issue.