Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BIDS import] Relation between Electrodes and physiological files #908

Merged
merged 1 commit into from
Mar 30, 2023
Merged

[BIDS import] Relation between Electrodes and physiological files #908

merged 1 commit into from
Mar 30, 2023

Conversation

regisoc
Copy link
Contributor

@regisoc regisoc commented Mar 24, 2023 •
edited
Loading

Description

Currently, the relation between physiological files and Electrodes is broken.
This PR fix this missing relation.

Resolves #907

Test procedure

  1. Put a BIDS archive that contains multiple coordinate systems in the incoming folder.
  2. Run the BIDS import pipeline.
  3. Once done, see if the table physiological_coord_system_electrode_rel contains all information needed.

@regisoc regisoc self-assigned this Mar 24, 2023
@cmadjar
Copy link
Collaborator

cmadjar commented Mar 27, 2023

@jeffersoncasimir @laemtl any chance one of you guys can test this PR?

@jeffersoncasimir jeffersoncasimir self-requested a review March 27, 2023 16:06
jeffersoncasimir
jeffersoncasimir approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@jeffersoncasimir jeffersoncasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as intended.

@cmadjar cmadjar merged commit a59ecb6 into aces:main Mar 30, 2023
@cmadjar cmadjar added this to the 25.0.0 milestone Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffersoncasimir jeffersoncasimir jeffersoncasimir approved these changes

Assignees

@regisoc regisoc

Labels
None yet
Projects
None yet
Milestone
25.0.0
Development

Successfully merging this pull request may close these issues.

[BIDS import] Electrode-Physiological file relation
3 participants
@regisoc @cmadjar @jeffersoncasimir