Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

candID subject_id support #912

Merged
merged 2 commits into from
Apr 14, 2023
Merged

candID subject_id support #912

merged 2 commits into from
Apr 14, 2023

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Apr 3, 2023 •
edited
Loading

  • Adds support for the CandID in the participants.tsv's subject_id fields
  • Adds support for the CAND_ID/PSCID validation (match) in the folder name if the flag -i is used

@laemtl laemtl force-pushed the candid-support branch 2 times, most recently from 6877e7f to f69298f Compare April 3, 2023 15:35
@laemtl laemtl changed the base branch from main to 24.1-release April 3, 2023 15:40
@laemtl laemtl changed the base branch from 24.1-release to main April 3, 2023 15:44
@laemtl laemtl changed the base branch from main to 24.1-release April 3, 2023 15:55
@laemtl laemtl requested review from regisoc and cmadjar and removed request for regisoc April 3, 2023 16:03
cmadjar
cmadjar requested changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@cmadjar cmadjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laemtl One tiny change, otherwise works great.

python/lib/exitcode.py Outdated Show resolved Hide resolved
@laemtl laemtl requested a review from cmadjar April 14, 2023 12:58
cmadjar
cmadjar approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@cmadjar cmadjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for implementing this @laemtl!

@cmadjar cmadjar merged commit 49697a4 into aces:24.1-release Apr 14, 2023
@cmadjar cmadjar added this to the 24.1.11 milestone Apr 14, 2023
@cmadjar cmadjar added Add to release notes A-BIDS Area: BIDS. Issues and pull requests related to BIDS and the BIDS import pipeline labels Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmadjar cmadjar cmadjar approved these changes

Assignees
No one assigned
Labels
A-BIDS Area: BIDS. Issues and pull requests related to BIDS and the BIDS import pipeline Add to release notes
Projects
None yet
Milestone
24.1.11
Development

Successfully merging this pull request may close these issues.
2 participants
@laemtl @cmadjar