Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mkdir to make_path in run_defacing_script.pl #978

Merged
merged 1 commit into from
May 5, 2023

Conversation

cmadjar
Copy link
Collaborator

@cmadjar cmadjar commented May 5, 2023

Description

This should fix the issue @zaliqarosli was having when testing run_defacing_script.pl. Use make_path from File::Path instead of mkdir when creating the output directory for the pipeline.

@zaliqarosli
Copy link
Contributor

zaliqarosli commented May 5, 2023

this is directly fixing the error with deface_minipipe.pl. running

deface_minipipe.pl /data/Loris-MRI/data/assembly/676061/V1/mri/native/demo_676061_V1_t1_001.mnc /data/Loris-MRI/data/assembly/676061/V1/mri/native/demo_676061_V1_t2_001.mnc /data/Loris-MRI/data/assembly/676061/V1/mri/native/demo_676061_V1_t2_001.mnc /data/Loris-MRI/data/assembly/676061/V1/mri/native/demo_676061_V1_t2_001.mnc /data/tmp/deface-tmVg7Wve/676061/V1/demo_676061_V1 --keep-real-range --beastlib /opt/minc/1.9.18/../share/beast-library-1.1  --model mni_icbm152_t1_tal_nlin_sym_09c  --model-dir /opt/minc/1.9.18/../share/icbm152_model_09c

works well, with defaced mincs appearing in /data/tmp/deface-tmVg7Wve/676061/V1.
but i'm still getting an error with running run_defacing_script.pl -profile prod -sessionIDs 2145:

Transforming slices:................................................................................................................................................................Done
Transforming slices:..........................................................................................Done
Copying chunks:.Done.
Transforming slices:................................................................................................................................................................Done
Copying chunks:................................................................................................................................................................Done.
Copying chunks:................................................................................................................................................................Done.
Constant subroutine NeuroDB::objectBroker::ConfigOB::CREATE_CANDIDATES redefined at /usr/lib/x86_64-linux-gnu/perl-base/constant.pm line 171.
PSCID is: DCC292
 CandID id: 676061
 visit_label is: V1
Argument "8Exiting now\n\n" isn't numeric in right bitshift (>>) at /opt/Loris-MRI/bin/mri/tools/run_defacing_script.pl line 682.
Argument "\nAn error occurred when running register_processed_data..." isn't numeric in right bitshift (>>) at /opt/Loris-MRI/bin(

and processed defaced files/dir not appearing in /data/Loris-MRI/data/assembly/676061/V1/mri/

@cmadjar
Copy link
Collaborator Author

cmadjar commented May 5, 2023

@zaliqarosli I have a feeling the second bug is related to register_processed_data script. I will merge this PR and maybe you can create a new issue for the defacing pipeline with the error you wrote above?

@cmadjar cmadjar merged commit 8de8ce0 into aces:main May 5, 2023
@zaliqarosli
Copy link
Contributor

new issue created #982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[run_defacing_script.pl] Images not defacing
2 participants