Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CenterID of the candidate table to RegistrationCenterID (part 1 of candidate's CenterID refactoring) #4057

Closed
14 tasks done
cmadjar opened this issue Nov 5, 2018 · 2 comments
Assignees
Labels
SQL PR contains SQL modifications such as schema changes and new SQL scripts

Comments

@cmadjar
Copy link
Collaborator

cmadjar commented Nov 5, 2018

This will be part 1 of the future for the CenterID field of the candidate table plan (as discussed in September 2018 with @samirdas @driusan and @ridz1208, see meetings notes).

TODOs:

Rename the CenterID field column of the candidate table to RegistrationCenterID, which correspond to the CenterID at which the candidate was first registered. This should never be changed for a given candidate.

The future PR should include:

  • the change of the SQL column name to RegistrationCenterID
  • the updates to some of the queries in the code to use that new column name
  • the changes of some of the queries to use s.CenterID when possible (ensure there is not duplication of the data displayed when doing so and that it does not affect the numbers)

Extra notes to not forget for this PR:

  • tools directory: grep for c.CenterID and CenterID and check if need to replace it by s.CenterID or c.RegistrationCenterID
  • Raisinbread dataset: might need to be fixed for this PR
  • Test suites: they might most probably break
  • API v0.0.3-dev
  • API v0.0.2 (only MySQL queries should be fixed according to @driusan)
  • Update LORIS-MRI code as well with new field name

Development notes:

Future labels for the PR:

  • SQL
  • [branch] major
  • Add to release notes, Document at release and Notes for existing projects: the RegistrationCenterID should never be changed for a given candidate. The session table will have the information about the latest CenterID the candidate has been seen.
  • Caveat for existing projects: make sure that c.CenterID is replaced by c.RegistrationCenterID in your project code queries.
@cmadjar cmadjar added SQL PR contains SQL modifications such as schema changes and new SQL scripts [branch] major labels Nov 5, 2018
@cmadjar cmadjar self-assigned this Nov 5, 2018
@cmadjar cmadjar changed the title Rename CenterID of the candidate table to RegistrationCenterID Rename CenterID of the candidate table to RegistrationCenterID Nov 5, 2018
@cmadjar cmadjar changed the title Rename CenterID of the candidate table to RegistrationCenterID Rename CenterID of the candidate table to RegistrationCenterID (part 1 of candidate's CenterID refactoring) Nov 5, 2018
@cmadjar
Copy link
Collaborator Author

cmadjar commented Nov 6, 2018

@driusan @ridz1208 Should I update the queries of API v0.0.2? Updated v0.0.3-dev so far. Waiting for your feedback on this one.

PS: just realized this place is probably better to ask you than Slack so everything is in the issue ;)

@cmadjar
Copy link
Collaborator Author

cmadjar commented Jan 30, 2019

PR was merged. First part of the mission done!

@cmadjar cmadjar closed this as completed Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL PR contains SQL modifications such as schema changes and new SQL scripts
Projects
None yet
Development

No branches or pull requests

1 participant