Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JWT Token Authentication #1421

Merged
merged 24 commits into from
Mar 4, 2016
Merged

JWT Token Authentication #1421

merged 24 commits into from
Mar 4, 2016

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented Nov 19, 2015

This adds support for the final piece of v0.0.1 of the LORIS API, user authentication with JWT tokens. Users can now post to login in the API with a valid username and password to receive a token which can be used for authentication in an Authorization: HTTP header.

The login page is also updated to use the API's authentication via javascript, so that we're using our own API.

@driusan driusan added Category: Bug PR or issue that aims to report or fix a bug Category: Feature PR or issue that aims to introduce a new feature Cleanup PR or issue introducing/requiring at least one clean-up operation labels Nov 19, 2015
@driusan driusan added this to the 16.04 milestone Nov 19, 2015
@jstirling91
Copy link
Contributor

Get a 500 Internal Server Error when posting to /login. The error log says

Config setting JWTKey does not exist in database

Should this setting be added to the XML or the Database?

@jstirling91 jstirling91 self-assigned this Nov 20, 2015
@driusan driusan assigned driusan and unassigned jstirling91 Dec 2, 2015
@driusan driusan force-pushed the JWTAuth branch 2 times, most recently from f4f5a49 to 231d8ef Compare December 18, 2015 14:58
@samirdas
Copy link
Contributor

Put a release note for this pull request if it still fails PHP 5.4. Watch this!

@christinerogers christinerogers added Release: Add to release notes PR whose changes should be highlighted in the release notes Release: Breaking changes PR that contains changes that might impact the code or accepted practices of active projects labels Dec 18, 2015
@driusan driusan force-pushed the JWTAuth branch 2 times, most recently from 647a781 to 053cbd3 Compare January 18, 2016 15:38
Removed PHP 5.4 from Travis.
be945d4 
Our official support policy is now to support the last 2 PHP releases
at the time of the major release. Today, that would be 5.6 and 7.0.
@driusan driusan assigned jstirling91 and unassigned driusan Mar 3, 2016
@codecov-io
Copy link

Current coverage is 15.08%

Merging #1421 into 16.04-dev will increase coverage by +0.05% as of 217aa11

@@            16.04-dev   #1421   diff @@
=========================================
  Files             108     108       
  Stmts           18313   18339    +26
  Branches            0       0       
  Methods          1027    1029     +2
=========================================
+ Hit              2754    2766    +12
  Partial             0       0       
- Missed          15559   15573    +14

Review entire Coverage Diff as of 217aa11

Powered by Codecov. Updated on successful CI builds.

samirdas
samirdas reviewed Mar 4, 2016
View reviewed changes
SQL/0000-00-03-ConfigTables.sql
@@ -166,3 +170,5 @@ INSERT INTO Config (ConfigID, Value) SELECT ID, "mri_parameter_form" FROM Config
INSERT INTO Config (ConfigID, Value) SELECT ID, "no-reply@example.com" FROM ConfigSettings WHERE Name="From";
INSERT INTO Config (ConfigID, Value) SELECT ID, "no-reply@example.com" FROM ConfigSettings WHERE Name="Reply-to";
INSERT INTO Config (ConfigID, Value) SELECT ID, "Produced by LorisDB" FROM ConfigSettings WHERE Name="X-MimeOLE";

INSERT INTO Config (ConfigID, Value) SELECT ID, "S3cret" FROM ConfigSettings WHERE Name="JWTKey";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make a note in the documentation not in the installation for developers to change.

@samirdas samirdas added the Release: Document at release PR whose changes need to be documented in the wiki (or other documentation) at release label Mar 4, 2016
samirdas added a commit that referenced this pull request Mar 4, 2016
@samirdas
Merge pull request #1421 from driusan/JWTAuth
ebf2806 
JWT Token Authentication
@samirdas samirdas merged commit ebf2806 into aces:16.04-dev Mar 4, 2016
@christinerogers
Copy link
Contributor

This pull request means you have run composer update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jstirling91 jstirling91

Labels
Category: Bug PR or issue that aims to report or fix a bug Category: Feature PR or issue that aims to introduce a new feature Cleanup PR or issue introducing/requiring at least one clean-up operation Release: Add to release notes PR whose changes should be highlighted in the release notes Release: Breaking changes PR that contains changes that might impact the code or accepted practices of active projects Release: Document at release PR whose changes need to be documented in the wiki (or other documentation) at release
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@driusan @jstirling91 @samirdas @codecov-io @christinerogers