Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imaging Browser: Added SNR for some imaging modalities (Redmine 1622) #1993

Merged
merged 9 commits into from
Jul 28, 2016

Conversation

MounaSafiHarab
Copy link
Contributor

@MounaSafiHarab MounaSafiHarab commented Jul 12, 2016

ImagePanel now has an SNR field that gets computed during image insertion into the database (using Loris-MRI preprocessing scripts).
Modalities included are typically t1, t2, flair, and pd (mostly 3-D images; no 4-D images such as DTI and fMRI).

To be used with:
aces/dicom-archive-tools#37
and
aces/Loris-MRI#142

@MounaSafiHarab MounaSafiHarab added Release: Add to release notes PR whose changes should be highlighted in the release notes Category: Feature PR or issue that aims to introduce a new feature SQL PR contains SQL modifications such as schema changes and new SQL scripts labels Jul 12, 2016
@MounaSafiHarab MounaSafiHarab added this to the 16.1 milestone Jul 12, 2016
@MounaSafiHarab
Copy link
Contributor Author

this should be 17.0 I guess due to the addition of the column into the files table?

@codecov-io
Copy link

codecov-io commented Jul 12, 2016

Current coverage is 14.06%

Merging #1993 into 16.1-dev will decrease coverage by <.01%

@@           16.1-dev      #1993   diff @@
==========================================
  Files           117        117          
  Lines         19829      19838     +9   
  Methods        1103       1104     +1   
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           2791       2791          
- Misses        17038      17047     +9   
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by f9690a3...d3fd487

@MounaSafiHarab MounaSafiHarab added the State: Needs work PR awaiting additional work by the author to proceed label Jul 14, 2016
@MounaSafiHarab
Copy link
Contributor Author

add to parameter_files table instead of files as per Dave's comment

@MounaSafiHarab MounaSafiHarab removed the State: Needs work PR awaiting additional work by the author to proceed label Jul 15, 2016
@driusan driusan merged commit 6cf112e into aces:16.1-dev Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Feature PR or issue that aims to introduce a new feature Release: Add to release notes PR whose changes should be highlighted in the release notes SQL PR contains SQL modifications such as schema changes and new SQL scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants