-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imaging Browser: Added SNR for some imaging modalities (Redmine 1622) #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounaSafiHarab
added
Release: Add to release notes
PR whose changes should be highlighted in the release notes
Category: Feature
PR or issue that aims to introduce a new feature
SQL
PR contains SQL modifications such as schema changes and new SQL scripts
labels
Jul 12, 2016
this should be 17.0 I guess due to the addition of the column into the files table? |
This was referenced Jul 12, 2016
Current coverage is 14.06%@@ 16.1-dev #1993 diff @@
==========================================
Files 117 117
Lines 19829 19838 +9
Methods 1103 1104 +1
Messages 0 0
Branches 0 0
==========================================
Hits 2791 2791
- Misses 17038 17047 +9
Partials 0 0
|
MounaSafiHarab
added
the
State: Needs work
PR awaiting additional work by the author to proceed
label
Jul 14, 2016
add to parameter_files table instead of files as per Dave's comment |
MounaSafiHarab
removed
the
State: Needs work
PR awaiting additional work by the author to proceed
label
Jul 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category: Feature
PR or issue that aims to introduce a new feature
Release: Add to release notes
PR whose changes should be highlighted in the release notes
SQL
PR contains SQL modifications such as schema changes and new SQL scripts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImagePanel now has an SNR field that gets computed during image insertion into the database (using Loris-MRI preprocessing scripts).
Modalities included are typically t1, t2, flair, and pd (mostly 3-D images; no 4-D images such as DTI and fMRI).
To be used with:
aces/dicom-archive-tools#37
and
aces/Loris-MRI#142