-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json Instruments V1 - WIP #3136
Conversation
Fixed user project multi-select display
…evaluated on the fly)
* reset radio * refactor * fixed padding * Update InstrumentForm.js * fixed indentation, key, for loop
* insert into test_names * special char fix
@driusan Addressed your comments. Still need to fix one test and do javascript linting though. |
The React components are in need of some optimization. For most instruments it isn't an issue but while testing one of our instruments (which contains 704 elements) we noticed significant slow-downs, mostly when editing a text box. As far as I can tell there are two causes:
Here are some ideas for optimizing:
|
@ZainVirani is working on splitting this up, but I'm adding the Block tag and leaving this open so we don't forget about it. |
This work is referenced in Redmine ticket #13780 |
WIP PR to facilitate conversation