Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[document_repository] Solves special characters issue #7383

Merged
merged 5 commits into from
Apr 15, 2021
Merged

[document_repository] Solves special characters issue #7383

merged 5 commits into from
Apr 15, 2021

Conversation

pierre-p-s
Copy link
Contributor

Brief summary of changes

Solves an issue when if using special characters (&, <, >, ") the file download fails and the name of the file appears incorrectly in the browse tab of the document repository

Testing instructions (if applicable)

  1. Upload a file with special charcacters &, <, >, " into the document repository.
  2. Look for the file in the file tree, check that the file name appears correctly
  3. Try downloading the file and opening it.

@kongtiaowang
Copy link
Contributor

I only tested the file name with ">" or "<". It works.
I can't create a file name with '"' in my OS.

@kongtiaowang kongtiaowang added the Passed manual tests PR has been successfully tested by at least one peer label Mar 11, 2021
kongtiaowang
kongtiaowang approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pierre-p-s
Copy link
Contributor Author

@ridz1208 If we could add this PR to the 23 bugfix release it would be great

@ridz1208 ridz1208 added State: Needs work PR awaiting additional work by the author to proceed and removed Passed manual tests PR has been successfully tested by at least one peer labels Mar 18, 2021
@pierre-p-s pierre-p-s removed the State: Needs work PR awaiting additional work by the author to proceed label Mar 23, 2021
@pierre-p-s
Copy link
Contributor Author

This PR still needs a script to change the file names in the sql table as well as in /data/document_repository_uploads

@pierre-p-s pierre-p-s added the State: Needs work PR awaiting additional work by the author to proceed label Mar 24, 2021
@pierre-p-s pierre-p-s removed the State: Needs work PR awaiting additional work by the author to proceed label Apr 3, 2021
@pierre-p-s
Copy link
Contributor Author

The script works on my VM but I cant seem to find why the test suite is failing.

@pierre-p-s pierre-p-s added the "Help! I don't understand Travis!" PR is having a beef with TRAVIS. Someone needs to help label Apr 6, 2021
@kongtiaowang kongtiaowang reopened this Apr 9, 2021
@kongtiaowang kongtiaowang removed the "Help! I don't understand Travis!" PR is having a beef with TRAVIS. Someone needs to help label Apr 9, 2021
@pierre-p-s
Copy link
Contributor Author

Thanks @kongtiaowang

@kongtiaowang kongtiaowang added the Passed manual tests PR has been successfully tested by at least one peer label Apr 9, 2021
kongtiaowang
kongtiaowang approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit 26df13e into aces:23.0-release Apr 15, 2021
@pierre-p-s pierre-p-s mentioned this pull request Apr 16, 2021
Merged
driusan pushed a commit that referenced this pull request Apr 20, 2021
@pierre-p-s
[document_repository] Fix special characters script (#7428)
7c195a3 
Fixes script from this PR #7383

See comment from #7386
@ridz1208 ridz1208 added this to the 23.0.3 milestone Apr 20, 2021
@ridz1208 ridz1208 mentioned this pull request Aug 17, 2021
Closed
ridz1208
ridz1208 reviewed Feb 5, 2022
View reviewed changes
tools/single_use/Cleanup_Special_Chars_Document_Repository.php
@@ -0,0 +1,55 @@
<?php
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before SQL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ridz1208 ridz1208 ridz1208 left review comments

@kongtiaowang kongtiaowang kongtiaowang approved these changes

Assignees
No one assigned
Labels
Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Milestone
23.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@pierre-p-s @kongtiaowang @ridz1208 @driusan