Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[candidate_parameters] Participant status - mandatory comments if not active or complete #8731

Conversation

charlottesce
Copy link
Contributor

Brief summary of changes

For Participant Status, make comments mandatory when setting the status to anything other than "Active" or "Complete".

Testing instructions (if applicable)

  1. Go to Candidate -> Access Profiles
  2. Select any participant
  3. Go to Candidate Info -> Participant Status
  4. Try updating the participant status to "Active", then "Complete" and ensure comments aren't mandatory.
  5. Try updating the participant status to all other statuses and ensure comments are mandatory i.e., that an error message pops up when trying to update without comments.

Note

This is a CCNA override - https://github.com/aces/CCNA/pull/6311

@driusan driusan added the Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties label Jun 7, 2023
@driusan
Copy link
Collaborator

driusan commented Jun 7, 2023

Can you add this to the LORIS meeting to discuss if this behaviour makes sense for all projects?

@charlottesce charlottesce removed the Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties label Jun 15, 2023
@charlottesce
Copy link
Contributor Author

It was decided at the meeting to include this PR in the next release.

@laemtl laemtl self-requested a review August 10, 2023 15:34
@driusan driusan merged commit 24a5b82 into aces:main Aug 16, 2023
@ridz1208 ridz1208 added this to the 26.0.0 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants