Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Scan done' field from 'Start visit' menu #8955

Merged

Conversation

GeorgeMurad
Copy link
Contributor

Brief summary of changes

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. click on Create time point under any candidate profile. And create a time point for a new visit.
  2. Open the visit you created and click on the button Start Visit Stage on the top left.
  3. You shouldn't see the scan done dropdown menu under the /next_stage module

Link(s) to related issue(s)

@GeorgeMurad GeorgeMurad self-assigned this Nov 15, 2023
@kongtiaowang
Copy link
Contributor

@GeorgeMurad to pass the test please delete 161 to 164 and 199 to 202 in modules/next_stage/test/next_stageTest.php

@kongtiaowang
Copy link
Contributor

@GeorgeMurad you need to delete "Scan done is required" rule.

Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit 58a4ee8 into aces:main Nov 17, 2023
19 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Apr 9, 2024
@CamilleBeau CamilleBeau mentioned this pull request May 6, 2024
1 task
driusan pushed a commit that referenced this pull request May 6, 2024
This updates the test plan of next_stage module because there is no longer a "scan done" option (#8955). This step is removed from the testing instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants