Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[candidate_parameters] Fix loading of candidate_parameters page #8973

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented Nov 21, 2023

The candidate_parameters pages were missing a number of import statements for elements from Form.js, making the page not load. This adds the missing imports.

Resolves #8968

@driusan driusan added the Category: Bug PR or issue that aims to report or fix a bug label Nov 21, 2023
@driusan
Copy link
Collaborator Author

driusan commented Nov 21, 2023

@CamilleBeau

@CamilleBeau CamilleBeau added the Passed manual tests PR has been successfully tested by at least one peer label Dec 1, 2023
@CamilleBeau
Copy link
Contributor

Everything looks good apart from Makefile conflict!

The candidate_parameters pages were missing a number of import statements
for elements from Form.js, making the page not load. This adds the missing
imports.

Resolves aces#8968
@driusan driusan force-pushed the FixCandidateParametersLoading branch from a5c89b5 to 9b50b02 Compare December 1, 2023 19:50
@driusan driusan merged commit bf24590 into aces:main Dec 1, 2023
19 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug PR or issue that aims to report or fix a bug Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[candidate_parameters] Blank page when accessing module
3 participants