[electrophysiology_browser] Minor HED display modifications #9166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffersoncasimir
added
Critical to release
6 tasks
inthe Dataset Tag Manager, user also has to select a Column Value, not just Column Name
christinerogers
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
tested this on https://jcasimir-eegnet-dev.loris.ca/electrophysiology_browser/sessions/2909?outputType=raw
Added one commit to update a user-facing message.
The rest of my review feedback has been added in issues in the EEGNet repo so / since they won't hold up the release.
approving for now. thanks @jeffersoncasimir !
|
@driusan @kongtiaowang I think this can be merged and pulled to Testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9164.